Skip to content

Commit

Permalink
INSTANTIATE_TEST_CASE_P -> INSTANTIATE_TEST_SUITE_P
Browse files Browse the repository at this point in the history
Chromium change:

https://chromium.googlesource.com/chromium/src/+/b0690d7d072abb

commit b0690d7d072abb347dee0b656e49d29602f0a8f3
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date:   Wed Oct 13 20:20:47 2021 +0000

    Roll GoogleTest from 075810f7a204 to 16f637fbf4ff (4 revisions)

    https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/075810f7a204..16f63 fbf4ff

    2021-10-13 absl-team@google.com Googletest export
    2021-10-13 absl-team@google.com Googletest export
    2021-10-13 asoffer@google.com Merge pull request #3602 from yesudeep:try-fix-linker-errors-on-freebsd
    2021-10-13 absl-team@google.com Googletest export
  • Loading branch information
mkarolin committed Oct 23, 2021
1 parent a190ad6 commit 61e78c4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -590,28 +590,28 @@ TEST_P(InstallStaticUtilTest, GetChromeChannel) {

#if defined(OFFICIAL_BUILD)
// Stable supports user and system levels.
INSTANTIATE_TEST_CASE_P(Stable,
INSTANTIATE_TEST_SUITE_P(Stable,
InstallStaticUtilTest,
testing::Combine(testing::Values(STABLE_INDEX),
testing::Values("user", "system")));
// Beta supports user and system levels.
INSTANTIATE_TEST_CASE_P(Beta,
INSTANTIATE_TEST_SUITE_P(Beta,
InstallStaticUtilTest,
testing::Combine(testing::Values(BETA_INDEX),
testing::Values("user", "system")));
// Dev supports user and system levels.
INSTANTIATE_TEST_CASE_P(Dev,
INSTANTIATE_TEST_SUITE_P(Dev,
InstallStaticUtilTest,
testing::Combine(testing::Values(DEV_INDEX),
testing::Values("user", "system")));
// Canary is only at user level.
INSTANTIATE_TEST_CASE_P(Nightly,
INSTANTIATE_TEST_SUITE_P(Nightly,
InstallStaticUtilTest,
testing::Combine(testing::Values(NIGHTLY_INDEX),
testing::Values("user")));
#else // OFFICIAL_BUILD
// Chromium supports user and system levels.
INSTANTIATE_TEST_CASE_P(Development,
INSTANTIATE_TEST_SUITE_P(Development,
InstallStaticUtilTest,
testing::Combine(testing::Values(DEVELOPER_INDEX),
testing::Values("user", "system")));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ TEST_P(MakeProductDetailsTest, UpdateCohortName) {
}
}

INSTANTIATE_TEST_CASE_P(All,
INSTANTIATE_TEST_SUITE_P(All,
MakeProductDetailsTest,
testing::ValuesIn(kTestData));

Expand Down

0 comments on commit 61e78c4

Please sign in to comment.