Merge pull request #25496 from brave/ios-fix-tempdoc-share

[iOS] Show correct options when sharing a temporary doc like a PDF
brave · Sep 10, 2024 · c790d67 · c790d67
2 parents e23684f + 315c4bd
commit c790d67
Showing 1 changed file with 20 additions and 20 deletions.
diff --git a/...e-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+WKNavigationDelegate.swift b/...e-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+WKNavigationDelegate.swift
@@ -756,10 +756,6 @@ extension BrowserViewController: WKNavigationDelegate {
       return .download
     }
 
-    if canShowInWebView {
-      return .allow
-    }
-
     // Check if this response should be handed off to Passbook.
     if shouldDownloadNavigationResponse {
       shouldDownloadNavigationResponse = false
@@ -769,6 +765,26 @@ extension BrowserViewController: WKNavigationDelegate {
       }
     }
 
+    // If the content type is not HTML, create a temporary document so it can be downloaded and
+    // shared to external applications later. Otherwise, clear the old temporary document.
+    if let tab = tab, navigationResponse.isForMainFrame {
+      if response.mimeType?.isKindOfHTML == false, let request = request {
+        tab.temporaryDocument = TemporaryDocument(
+          preflightResponse: response,
+          request: request,
+          tab: tab
+        )
+      } else {
+        tab.temporaryDocument = nil
+      }
+
+      tab.mimeType = response.mimeType
+    }
+
+    if canShowInWebView {
+      return .allow
+    }
+
     // Check if this response should be downloaded.
     let cookieStore = webView.configuration.websiteDataStore.httpCookieStore
     if let downloadHelper = DownloadHelper(
@@ -796,22 +812,6 @@ extension BrowserViewController: WKNavigationDelegate {
       return .cancel
     }
 
-    // If the content type is not HTML, create a temporary document so it can be downloaded and
-    // shared to external applications later. Otherwise, clear the old temporary document.
-    if let tab = tab, navigationResponse.isForMainFrame {
-      if response.mimeType?.isKindOfHTML == false, let request = request {
-        tab.temporaryDocument = TemporaryDocument(
-          preflightResponse: response,
-          request: request,
-          tab: tab
-        )
-      } else {
-        tab.temporaryDocument = nil
-      }
-
-      tab.mimeType = response.mimeType
-    }
-
     // If none of our helpers are responsible for handling this response,
     // just let the webview handle it as normal.
     return .download