Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Show correct options when sharing a temporary doc like a PDF #25496

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

kylehickinson
Copy link
Collaborator

Resolves brave/brave-browser#40918

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Sep 9, 2024
@kylehickinson kylehickinson self-assigned this Sep 9, 2024
@kylehickinson kylehickinson requested a review from a team as a code owner September 9, 2024 21:50
Copy link
Contributor

@Brandon-T Brandon-T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. It works and still mitigates the flaw.
Tested 1.68.x to confirm the flaw is there.
Tested this PR to confirm the flaw is NOT there.
Tested Sharing (Save PDF to Files) and Apple Wallet (Cineplex Tickets)

@kjozwiak
Copy link
Member

Verification PASSED on iPhone 11 running iOS 17.6.1 using the following build(s):

Brave | 1.71.80 Chromium: 128.0.6613.120 (Official Build) nightly (64-bit) 
--- | ---
Revision | 4dea6843510d...
OS | iOS

Using the STR/Cases outlined via brave/brave-browser#40918 (comment), ensured that Save to Files was available and worked as expected. Also ensured that Create PDF was also working and could be saved using Save to Files as per the following:

Ensuring you can save PDF files via Save to Files

Example Example Example Example Example
IMG_0540 IMG_0541 IMG_0542 IMG_0543 IMG_0544

Ensuring you can save websites as PDFs and save via Save to Files

Example Example Example Example
IMG_0545 IMG_0546 IMG_0547 IMG_0548

kjozwiak pushed a commit that referenced this pull request Sep 11, 2024
kjozwiak pushed a commit that referenced this pull request Sep 11, 2024
…plift to 1.69.x) (#25501)

Uplift of #25496 (squashed) to release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save to Files is missing from Share menu, and instead Create PDF is shown, which doesn't work at all
3 participants