Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow self-transfers in panel for cancel transactions #11231

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Conversation

onyb
Copy link
Member

@onyb onyb commented Nov 23, 2021

This PR fixes the following issues:

  • Do not refresh the entire wallet info on transaction approval/rejection.
  • Allow self-transfers in the wallet panel, for cancellation transactions.

Resolves brave/brave-browser#19642.
Resolves brave/brave-browser#19536 As this issue already going out in 1.32.x HF

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Demo

Screen.Recording.2021-11-23.at.9.40.58.AM.mov

@onyb onyb self-assigned this Nov 23, 2021
Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kjozwiak
Copy link
Member

Adding missing 1.34.x milestone 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to approve cancel transactions Swapping via Quickswap (Polygon/MATIC) chain shows insufficient funds
3 participants