-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wallet): reduce scope of address checks in useTransactionParser hook #11300
Conversation
04d432d
to
47f7157
Compare
CI failure on ios seems unrelated => failed to apply patches. |
47f7157
to
b68cbaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Great job on the Tests
!
Should we have a Security Review for @testing-library/react-hooks
?
@Douglashdaniel Yes, added an issue for the security review. |
I think the dep is ok but checking with @diracdeltas since it's new for: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Merging after green light by security team. |
Verification passed on
11300.-.ETH-WETH.Swap.mov
11300.-.Cancel.Transaction.mov |
Summary of changes:
ETHSend
, which is the type of cancel transactions.ERC20Transfer
,ERC721TransferFrom
, andERC721SafeTransferFrom
. The error in the linked issue was because ETH-WETH swap didn't use the 0x exchange router but actually the WETH contract directly.Resolves brave/brave-browser#19745.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Demo
Before
ETH-WETH.swap.error.mov
After
ETH-WETH.swap.mov
cancel.mov
Unit tests