-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Chromium 101 to Chromium 102. #12837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdesouza-chromium
force-pushed
the
cr102
branch
5 times, most recently
from
April 5, 2022 19:07
b55e673
to
bf26294
Compare
cdesouza-chromium
force-pushed
the
cr102
branch
7 times, most recently
from
April 11, 2022 18:33
696285b
to
cb1faf7
Compare
cdesouza-chromium
force-pushed
the
cr102
branch
from
April 14, 2022 20:53
be7b503
to
4c8bcd8
Compare
emerick
force-pushed
the
cr102
branch
5 times, most recently
from
April 16, 2022 21:13
8685f39
to
5359b86
Compare
cdesouza-chromium
force-pushed
the
cr102
branch
6 times, most recently
from
April 22, 2022 16:05
98302ee
to
4ed4c90
Compare
cdesouza-chromium
force-pushed
the
cr102
branch
from
April 26, 2022 12:20
db89f5d
to
4385213
Compare
Chromium change: https://chromium.googlesource.com/chromium/src/+/6b031526902b8232aef756bd9d3f5665bbe623d5 commit 6b031526902b8232aef756bd9d3f5665bbe623d5 Author: Aishwarya Rajesh <aishwaryarj@google.com> Date: Fri Apr 29 17:17:56 2022 +0000 [Toolbar Tablet] Update touch target sizes for toolbar elements This CL updates the sizes of toolbar elements (location bar including action/status icon buttons) to be a minimum of 48dp. - The background drawable for the location bar is updated as an inset drawable to preserve the existing height of 40dp. - The StatusView height is not matching the parent height of 48dp, so the touch delegate height has been updated to satisfy minimum size requirements. - The StatusView start padding has been removed. - An end padding of 8dp has been added to the URL action container. This warranted an update to the URL bar text view margin calculations. Before: https://hsv.googleplex.com/6710528861798400?node=19 After: https://hsv.googleplex.com/6313415866843136?node=19 Bug: 1297681
… it is not behaving same as previous SetContentSettingRules which takes pointer. So we need to set new rules every time or GetRendererContentSettingRules and modify it. related upstream change https://chromium-review.googlesource.com/c/chromium/src/+/3540587
Replaced patch with resource override. Chromium change: https://chromium.googlesource.com/chromium/src/+/6b031526902b8232aef756bd9d3f5665bbe623d5 commit 6b031526902b8232aef756bd9d3f5665bbe623d5 Author: Aishwarya Rajesh <aishwaryarj@google.com> Date: Fri Apr 29 17:17:56 2022 +0000 [Toolbar Tablet] Update touch target sizes for toolbar elements This CL updates the sizes of toolbar elements (location bar including action/status icon buttons) to be a minimum of 48dp. - The background drawable for the location bar is updated as an inset drawable to preserve the existing height of 40dp. - The StatusView height is not matching the parent height of 48dp, so the touch delegate height has been updated to satisfy minimum size requirements. - The StatusView start padding has been removed. - An end padding of 8dp has been added to the URL action container. This warranted an update to the URL bar text view margin calculations. Before: https://hsv.googleplex.com/6710528861798400?node=19 After: https://hsv.googleplex.com/6313415866843136?node=19 Bug: 1297681
Chromium change: chromium/chromium@b964b99 Add logic to track suggestions list scroll events. This change allows us to learn how frequently our users need to scroll the suggestions list in order to find what they are looking for. Bug: 1291761
Chromium change: https://chromium.googlesource.com/chromium/src/+/6eb75d3c7b9ef4f90d7ee13471e0aac9f820967b commit 6eb75d3c7b9ef4f90d7ee13471e0aac9f820967b Author: Ian Vollick <vollick@chromium.org> Date: Fri Apr 22 21:44:59 2022 +0000 [mparch] Add and start using Frame::IsCrossOriginToOutermostMainFrame With MPArch we can have a nested main frame, so for cases when we want to check that an embedded frame is cross-origin with respect to the outermost main frame, we should use IsCrossOriginToOutermostMainFrame. This CL changes a number of cases where the semantics appear to match outermost. This should have no effect outside the use of MPArch-based nested frame trees (only fenced frames at the moment). However, this is an interim step: the vast majority of current IsCrossOriginToMainFrame usages should be comparing with the outermost main frame, not the nearest. Ultimately, we will rename IsCrossOriginToMainFrame -> IsCrossOriginToNearestMainFrame, which will be used rarely, with all other instances using the 'outermost' check. A TODO has been added over IsCrossOriginToMainFrame about this next step. TODOs have been added for test coverage of these changes, similar to the approach taken in crrev.com/c/2988476 and crrev.com/c/3577677. More will be added after the mass rename in the sebsequent CL. Bug: 1318055
This change improves the patch for this class by substituting the patch file with a macro override.
Chromium change: chromium/chromium@1b9e3f2 [TabletGTS] Fix polish toolbar for first relaunch and a11y switcher Fix polish toolbar for first relaunch and a11y switcher. -Pass both the fullscreen and non-fullscreen tab switcher toolbar stubs when the polished tablet GTS is enabled. -Choose which one to use based on our flag and if the a11y list switcher is enabled. (cherry picked from commit 50515c1) Bug: 1312980, 1317611
CI passed on all platforms; ready to merge. |
25 tasks
emerick
added a commit
that referenced
this pull request
May 16, 2022
Upgrade from Chromium 101 to Chromium 102.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#21976
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: