Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 101 to Chromium 102. #21976

Closed
mkarolin opened this issue Mar 30, 2022 · 6 comments · Fixed by brave/brave-core#12837
Closed

Upgrade from Chromium 101 to Chromium 102. #21976

mkarolin opened this issue Mar 30, 2022 · 6 comments · Fixed by brave/brave-core#12837

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Mar 30, 2022

Upgrade from Chromium 101 to Chromium 102.

https://chromium.googlesource.com/chromium/src/+log/101.0.4951.64..102.0.5005.50/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

  • Chromium sidebar toolbar icon removed and reading list panel deactivated
  • brave://settings search box
  • Content setting rules (affects adblock, autoplay allow/block settings, other content settings)
  • Protocol handlers for IPFS/IPNS
  • Component updater

Android Affected areas:

  • Top toolbar UI (sepecially tablet)
  • Bottom toolbar UI
  • New tab page UI
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 16, 2022

Verification PASSED on

Brave | 1.40.58 Chromium: 102.0.5005.50 (Official Build) nightly (64-bit)
-- | --
Revision | f6e2cf8f59ec714bdcff8499991d55898875f287-refs/branch-heads/5005@{#648}
OS | Windows 10 Version 21H2 (Build 19044.1706)

Chromium sidebar toolbar icon removed and reading list panel deactivated_PASSED
  • Confirmed Side panel flag is removed from brave://flags in 1.40.58 CR102
  • Confirmed reading list panel is deactivated in clean profile1.40.58 CR102
  • Installed 1.40.22 CR 101 and enable the Side panel flag in brave://flags and upgrade the profile to 1.40.58 CR102 and ensured the reading list panel is deactivated in an upgraded profile CR102
1.40.22 CR101 1.40.58 CR102
image image
brave://settings search box_PASSED
  • Confirmed that searching any string in the search box is working as expected
  • Confirmed that if search string is not found message is shown as expected
  • Confirmed that user can search a string using CTRL+F or click on the search icon in brave://settings
Example Example
image image
Component updater_PASSED
  • Confirmed new components Url Param Classifications is added as part of CR102
  • Click on Check for update for all the components and waited for 8 mins and confirmed components are up-to-date and version details are updated as expected
    image
Content setting rules_PASSED

Case 1:
24-hours, negative test (25 hours) (microphone):

  1. Clean profile 1.40.x
  2. load https://permission.site/
  3. click on Microphone
  4. give permission for 24 hours
  5. confirm brave://settings/content shows Allow for Microphone
  6. shut down Brave
  7. set system clock forward by 25 hours
  8. confirm brave://settings/content shows Ask (default) for Microphone
  9. load https://permission.site/
  10. confirm you get re-prompted for microphone permissions when clicking on Microphone

Case 2:

24-hours positive test (23 hours) (microphone):

  1. Clean profile 1.40.x
  2. load https://permission.site/
  3. click on Microphone
  4. give permission for 24 hours
  5. confirm brave://settings/content shows Allow for Microphone
  6. shut down Brave
  7. set system clock forward by 23 hours
  8. confirm brave://settings/content shows Allow for Microphone
  9. load https://permission.site/
  10. confirm you do NOT get re-prompted for microphone permissions when clicking on Microphone

Case 3:

1-week, negative test (8 days) (camera):

  1. Clean profile 1.40.x
  2. load https://permission.site/
  3. click on Camera
  4. give permission for 1 week
  5. confirm brave://settings/content shows Allow for Camera
  6. shut down Brave
  7. set system clock forward by 8 days
  8. confirm brave://settings/content shows "Ask (default) for Camera
  9. load https://permission.site/
  10. confirm you get re-prompted for microphone permissions when clicking on Camera

Case 4:
1-week, positive test (location):

  1. Clean profile 1.40.x
  2. load https://permission.site/
  3. click on Location
  4. give permission for 1 week
  5. confirm brave://settings/content shows Allow for Location
  6. shut down Brave
  7. set system clock forward by 6 days
  8. confirm brave://settings/content shows permission.sitewithAllowed locationunderRecent activity`
  9. load https://permission.site/
  10. confirm you do NOT get re-prompted for location permissions when clicking on Location
Protocol handlers for IPFS/IPNS_PASSED
  • Confirmed IPFS and IPNS protocol handlers message is shown under Show connection details
  • Confirmed user can enable IPFS/IPNS via websites
  • Confirmed IPFS and IPNS work fine
Example Example
image image

Components comparison

  • Confirmed new components Url Param Classifications is added as part of CR102 and the old component Autofill Regex Data is removed from CR102
  • Confirmed components are up-to-date and version details are updated as expected
1.40.58 1.38.118
image image

Settings comparison

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 12 running 1.40.58 x64 Nightly build

Top toolbar UI

  • Verified Disable bottom toolbar asks for relaunch
  • Verified disabling bottom toolbar shows the URL bar on top after relaunch
  • Verified able to open tabs in tab groups and tab count updates correctly
  • Verified able to swipe toolbar to switch between tabs
  • Verified no crash when swipe switch tabs
  • Verified no crash when opening tab tray
  • Verified no crash when opening menu items when toolbar is on top
  • Verified no crash when clicking shields button with toolbar on top
  • Verified no crash when clicking on rewards panel with toolbar on top

Bottom toolbar UI

  • Verified enabling Disable bottom toolbar asks for relaunch
  • Verified re-enabling bottom toolbar shows the URL bar on bottom after relaunch
  • Verified able to open tabs in tab groups and tab count updates correctly
  • Verified able to swipe bottom toolbar to switch between tabs
  • Verified no crash when swipe switch tabs
  • Verified no crash when opening tab tray
  • Verified no crash when opening menu items when toolbar is on top
  • Verified able to select home button without crashing the browser
  • Verified able to bookmark a page via the bottom toolbar shortcut
  • Verified clicking on the magnifying glass sets focus to URL bar
  • Verified able to switch between tabs and tabs group via swiping the bottom toolbar

New tab page UI

  • Verified NTP background images load correctly
  • Verified changing orientation causes NTP background to align horizontally
  • Verified NTP SI are shown correclty
  • Verified widgets and toptiles are shown correctly
  • Verified disabling Background images asks for a restart
  • Verified disabling background images shows 2 rows of top tiles
  • Verified clicking on stats brings up privacy report
  • Verified clicking on a top tile doesn't crash the browser

@Uni-verse
Copy link
Contributor

Uni-verse commented May 17, 2022

Verification PASSED on Samsung Galaxy Tab S7 using

Brave	1.40.62 Chromium: 102.0.5005.50 (Official Build) canary (64-bit) 
Revision	f6e2cf8f59ec714bdcff8499991d55898875f287-refs/branch-heads/5005@{#648}
OS	Android 12; Build/SP1A.210812.016

Top Toolbar UI

  • Home icon will navigate back to tab homepage
  • Toolbar back/forward nav arrows will navigate user accordingly
  • Refresh icon will refresh webpage
  • tapping SSL icon in the url bar will display SSL information
  • Able to bookmark using bookmark icon in the top tool bar
  • Able to download page using the shortcut on the tool bar
  • Tapping BR will display modal
  • Tapping Shields icon will bring up shields modal
  • tapping 3-dot menu will show menu

New Tab Page UI

  • Stats are shown correctly
  • Tapping Stats will load privacy report
  • Top Sites are displayed
  • Clicking on top site will load the URL
  • NTP background images are loaded
  • NTP SI are shown correctly
  • Disabling background images in settings shows 2 rows of top tiles on NTP
  • Disabling NTP SI will not load SI
  • Opt-in card for brave news is shown
  • Enabling brave news will display feed
1 2 3 4 5
screenshot-1652814445980 screenshot-1652812281585 screenshot-1652813874101 screenshot-1652814414865 screenshot-1652814427829

@kjozwiak
Copy link
Member

Added release-notes/exclude in favour of #22923. As mentioned via #22923 (comment), Linux & macOS still need to run through the affected areas. Other platforms can just ensure that the correct chromium version is being used.

@stephendonner
Copy link

Added release-notes/exclude in favour of #22923. As mentioned via #22923 (comment), Linux & macOS still need to run through the affected areas. Other platforms can just ensure that the correct chromium version is being used.

Ran through macOS-x64 via #22923 (comment) 👍

@btlechowski
Copy link

Verification passed on

Brave 1.39.111 Chromium: 102.0.5005.61 (Official Build) (64-bit)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS Ubuntu 18.04 LTS

Verified in #22923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment