Add "warning/confirmation" dialog when closing a window w/ multiple tabs #10430

Brave-Matt · 2020-06-23T18:16:21Z

Description

Several users have requested the option to confirm whether or not they want to close a window when multiple tabs are open in it. This functionality would be similar to what is already implemented in other browsers like Firefox and IE:

This functionality would prevent users from inadvertently closing a browser window. Also note that this functionality exists when attempting to Quit the application process and even has an option to opt out of the Press to hold function:

Designs

Add the preference to warn when closing multiple tabs to the Help tips section in brave://settings. This is off by default.

Move Show warning before quitting with ⌘Q out of the Appearance section and to the Help Tips section too.

When toggled on, show a warning dialog when the user when closing multiple tabs.

Assets

Figma: https://www.figma.com/file/pVwKlNQJU9wTVOa9tImKpo/?node-id=318%3A9788

Miscellaneous Information:

Several users responding to this feature request -- will add additional request threads as I find them:
https://community.brave.com/t/five-years-and-no-progress-warn-before-closing-multiple-tabs/86525/7

The text was updated successfully, but these errors were encountered:

srirambv · 2020-06-24T04:26:20Z

Windows/Linux specific request as this is already available in macOS

AmbrocioIsaias2808 · 2020-07-02T18:02:02Z

I think it would be a good feature, sometimes i have to many tabs opened in two or more windows and closing one of them by accident is not very chirfull because i lost the tabs. I know now there is an option to restore them from history, but previous 9 days ago i didn´t know about it and like me there are lots. And well other browsers have this feature like opera, ¿why not brave?, i mean, it´s simple and not intrusive.

joemamabuckeye · 2020-07-08T14:58:39Z

I totally agree, this simple confirmation or warn dialog aka beforeunload event (like in a web page) is critical for the browser window that has multiple open tabs. I do a TON of research and go between 3 brave windows, having 10 or more tabs open on each... accidentally closing one of the browser windows instead of a tab is a real PITA. I cannot just go back to the history because some of the pages hadn't been visited recently enough...and 'recently closed' won't restore because you closed the entire window. I also use extensions like Flowbar, but I want some tabs open to jump back to in a second, not try to find the right bookmark and load the page, and my reference info. Saving everything to PDF isn't always feasible either.
I left FF because the multiple open tabs dragged my processor, but this is making me think about looking for another browser. Hoping for a solution!!!

srirambv · 2020-10-02T06:22:39Z

+1 from https://community.brave.com/t/warning-to-close-if-multiple-tabs-open/167327

ksalhab89 · 2020-11-08T09:49:35Z

+1

9codes · 2020-12-06T07:27:01Z

+1

9codes · 2020-12-06T07:35:28Z

Today I lost all of my working tabs just for not being this feature. As the progress was not saved, I lost all the hard work and time. Developers @mrobinson @marshall @bridiver @mattmcalister @pes10k should add this feature in a short time. Maybe it's a minor change for them but it's a major for me. Thanks.

bsclifton · 2020-12-07T07:06:38Z

@9codes it might be a bit late, but you can use a shortcut Ctrl + Shift + T (on macOS: Cmd + Shift + T) to restore your last closed tab / window. You can use this multiple times and you should be able to restore it. This works in Chromium and other browsers too

9codes · 2020-12-13T10:54:22Z

@bsclifton Thanks for your response Brian. I will wait (for the feature).

murad-alm · 2021-02-24T22:26:49Z

@brave Is there any chance we will get this simple feature anytime soon?
I really don't want to sound rude, but its literally one line of code...
if opened_tabs > 1: show_confirmation_dialog() else: exit()

pes10k · 2021-02-24T22:31:12Z

I believe this is already here (inherited from upstream / Chromium). Does this do what you're asking for?
brave://settings/?search=Show+warning+before+quitting?

It isn't specific to the "more than one tab" case, but it seems to solve the "whoops i didn't mean close and loose my stuff" problem.

If that doesn't capture whats needed, can you kindly share a bit more about whats further needed? Thanks!

murad-alm · 2021-02-24T22:37:01Z

I believe this is already here (inherited from upstream / Chromium). Does this do what you're asking for?
brave://settings/?search=Show+warning+before+quitting?

It isn't specific to the "more than one tab" case, but it seems to solve the "whoops i didn't mean close and loose my stuff" problem.

If that doesn't capture whats needed, can you kindly share a bit more about whats further needed? Thanks!

Dear @pes10k,
I can't find this option (Version 1.20.110 ) anywhere in the settings.
This functionality should (as described by @Brave-Matt) warn the user before closing the browser whenever more than one tab are open (please check the issue description).
Thanks!

pes10k · 2021-02-24T22:39:27Z

Just to make sure we're on the same page, you don't see the below in your settings?

murad-alm · 2021-02-24T22:41:34Z

Just to make sure we're on the same page, you don't see the below in your settings?

I believe this option is only available for macOS (as described by @srirambv ). Linux / Windows users DO NOT have this option.

bridiver · 2021-02-24T23:56:32Z

@murad-alm if you can write this feature in one line of code I would be happy to review the PR

@brave Is there any chance we will get this simple feature anytime soon?
I really don't want to sound rude, but its literally one line of code...
if opened_tabs > 1: show_confirmation_dialog() else: exit()

murad-alm · 2021-02-25T11:01:49Z

@murad-alm if you can write this feature in one line of code I would be happy to review the PR

@brave Is there any chance we will get this simple feature anytime soon?
I really don't want to sound rude, but its literally one line of code...
if opened_tabs > 1: show_confirmation_dialog() else: exit()

I apologize if my bad joke offended you. Have a nice day @bridiver !

bridiver · 2021-02-25T13:19:24Z

@murad-alm if you can write this feature in one line of code I would be happy to review the PR

@brave Is there any chance we will get this simple feature anytime soon?

I really don't want to sound rude, but its literally one line of code...

if opened_tabs > 1: show_confirmation_dialog() else: exit()

I apologize if my bad joke offended you. Have a nice day @bridiver !

@murad-alm we get some very interesting responses sometimes so it's not always easy to pick out the jokes ;)

zcraber · 2021-02-27T06:17:25Z

+1 This is a much-needed feature for me.

JakubBarta · 2021-03-07T22:51:57Z

+1 please implement this feature

DutchPete · 2022-05-05T15:12:27Z

General automation moved this from In progress to Completed 3 days ago

This is for Windows. What about Linux ???

simonhong · 2022-05-05T23:30:13Z

@DutchPete The fix for this issue (brave/brave-core#13003) is for all platforms.

MadhaviSeelam · 2022-05-25T15:21:03Z

Verification PASSED using

Brave | 1.40.74 Chromium: 102.0.5005.61 (Official Build) beta (64-bit)
-- | --
Revision | 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS | Windows 11 Version 21H2 (Build 22000.675)

Filed ##23090

Case 1: `Warn me before closing window with multiple tab` preference is added in brave://settings/HelpTips and is `disabled` as a default - PASSED

Install 1.40.x
Launch brave
Open brave://settings>>click Additional settings>>click Help tips
Verified `Warn me before closing window with multiple tab’ pref is available
The toggle is OFF by default

dark	light

Case 2: Basic Test- Show `Close all tabs` warning dialog upon closing multiple tabs, when the pref is `enabled` - PASSED

New profile
Launch brave
Create new window with multiple tabs
Leave the default selection for Continue where you left off in brave://settings/getStarted
Close the browser window ('x' or alt+f4)
Verified warning Close all tabs dialog is not launched since pref is OFF by default
Enable Warn me before closing window with multiple tabs in Help tips section of brave://settings
Close the browser window ('x' or alt+f4)
Verified Close all tabs dialog displayed with correct text
UI matched to figma
Click Cancel button
Warning dialog is dismissed
Close the browser window again ('x' or alt+f4)
Click Close all button in the Warning dialog
Relaunch the browser
All of the tabs are preserved

Step 3&4	Step 7	Step 9	Step 16

Case 3: Do not show `Close all tabs` warning dialog when the pref is `disabled` again OR `Don’t ask me again` check box is checked - PASSED

Continue from Case 2 (Pref is enabled)
Open multiple tabs
Leave the default selection for Continue where you left off in brave://settings/getStarted
Disable Warn me before closing window with multiple tabs pref in Help tips section of brave://settings
Close the browser window
Verified Close all tabs dialog not displayed
Relaunch the browser
All of the tabs are preserved
Enable the pref in the Help tips section of brave://settings
Close the browser window
Check the check box for Don’t ask me again
Click Close all button
Relaunch the browser
All tabs are preserved
Navigate to Help tips section of brave://settings
Verified Warn me before closing window with multiple tabs pref is disabled

Step2&3	Step4	Step11	Step14

Case 4: Test with `onbeforeunload` handler -PASSED

Launch Browser and set option is enabled
Create window and create more than one NTP tabs
Load https://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_onbeforeunload in one NTP and click Click here to go to w3schools.com and check beforeunload dialog is launched. Then, dismiss it.
Try to close window by clicking close button or window closing shortcut (alt + f4, or cmd+shift+w on macOS)
Select Close all and check beforeunload dialog is launched
Cancel beforeunload dialog
Repeat step 4 and check window Close all tabs is shown again
Select Close all and also Leave from beforeunload dialog and check window is closed

Step 1	Step2	Step3	Step4	Step5	Step7	Step8

Case 5: Test with download in-progress handler -PASSED

Fresh Install

Launch Browser and set option is enabled
Create window and create more than one NTP tabs
Load https://ubuntu.com/download/desktop/thank-you?version=22.04&architecture=amd64 and start download
3a. Tested with Acrobat reader download https://get.adobe.com/reader/?promoid=TTGWL47M as this can be tested with any
download
Try to close window by clicking close button or window closing shortcut (alt + f4, or cmd+shift+w on macOS)
Select Close all from window closing dialog and check Download in-progress warning dialog is launched
Select Continue downloading
Repeat step 4 and check window closing dialog is launched again
Select Close all from window closing dialog and select Exit from Download in-progress warning dialog
Check window is closed.

Ex1	Ex2	Ex3

Case 6: Test with onbeforeunload and download in-progress handler - PASSED

(Note: On macOS, download warning dialog is not shown on normal profile. Private window will have same behavior on macOS with other platform's normal window)

Fresh Install

Launch Browser and set option is enabled
Create window and create more than one NTP tabs
Load https://ubuntu.com/download/desktop/thank-you?version=22.04&architecture=amd64 and start download
Load https://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_onbeforeunload in one NTP and click Click here to go to w3schools.com and check beforeunload dialog is launched. Then, dismiss it.
Try to close window by clicking close button or window closing shortcut (alt + f4, or cmd+shift+w on macOS)
Check download warning or beforeunload dialog is launched one by one after selecting Close all from window closing dialog
Verified beforeunload dialog is launched after selecting Close All dialog

Ex1	Ex2	Ex3	Ex4	Ex5

Case 7:Test with reboot/restart - PASSED

Launch Browser and set option is enabled

Create window and create more than one NTP tabs

Load brave://restart and check window closing dialog is not launched

Repeat step 1,2 and load brave://quitand check window closing dialog is not launched

Verified Close all warning dialog is not launched for both restart and quit

Ex1	Ex2	Ex3

Case 8: Test with update - PASSED

Launch Browser and set option is enabled
Create window and more than one tab
Load brave://settings/help and waiting relaunch is ready after downloading new update
Click relaunch button and check window closing dialog is not launched
Verified Close all warning dialog is not launched upon update

Step1	Step3	Update

Case 9: Test with profile deletion -PASSED

Launch Browser and set option is enabled
Create window with more than one tabs
Delete active profile and check window closing confirm dialog is not launched.
Verified Close all warning dialog is not launched

Ex1	Ex2	Ex3

Case 10: Windows/Linux specific test - PASSED

Launch Browser and set option is enabled
Create window and create more than one NTP tabs
Repeat step 2 to recreate another window with multiple tabs
Do closing all windows from app icon's context menu at Dock(linux) or at Taskbar(Windows)
Check each Windows' closing is done separately like above
Verified Close all warning dialog is launched for both windows

window1	window2

Additional scenarios

Verified the Close all tabs warning dialog works as expected with Open the New Tab Page selection in brave://settings/getStarted
Verified the Close all tabs warning dialog works as expected with Open a specific page or set of pages selection in brave://settings/getStarted
Verified Close all tabs warning dialog works as expected with TOR window
Verified Close all tabs warning dialog works as expected with Private window

Test Case II Upgrade:

Upgrade Test - PASSED

Install 1.39.x

Create window with than one tab

Help tips section in brave://settings do not have Warn me before closing window with multiple tabs pref

Load brave://settings/help and wait for updates to complete

Click to Relaunch the browser

Verified Warn me before closing window with multiple tabs pref is available and set to OFF as a default

Ex1	Ex2	Ex3	Ex4

DutchPete · 2022-05-25T15:25:36Z

@MadhaviSeelam how about for Linux? Simon Hong mentioned on 16 May it would be done for Brave 1.40.

MadhaviSeelam · 2022-05-25T20:14:23Z

@DutchPete Linux will be tested as well in 1.40.x

stephendonner · 2022-06-01T18:08:34Z

Verification `PASSED` using

Brave	1.40.82 Chromium: 102.0.5005.78 (Official Build) beta (x86_64)
Revision	df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS	macOS Version 11.6.6 (Build 20G624)

Case 1: `Warn me before closing window with multiple tab` preference is added in brave://settings/HelpTips and is `disabled` as a default - PASSED

Install 1.40.x
Launch brave
Open brave://settings>>click Additional settings>>click Help tips
Verified `Warn me before closing window with multiple tab’ pref is available
The toggle is OFF by default

dark	light

Case 2: Basic Test- Show `Close all tabs` warning dialog upon closing multiple tabs, when the pref is `enabled` - PASSED

New profile
Launch brave
Create new window with multiple tabs
Leave the default selection for Continue where you left off in brave://settings/getStarted
Close the browser window ('x' or alt+f4)
Verified warning Close all tabs dialog is not launched since pref is OFF by default
Enable Warn me before closing window with multiple tabs in Help tips section of brave://settings
Close the browser window ('x' or alt+f4)
Verified Close all tabs dialog displayed with correct text
UI matched to figma
Click Cancel button
Warning dialog is dismissed
Close the browser window again ('x' or alt+f4)
Click Close all button in the Warning dialog
Relaunch the browser
All of the tabs are preserved

Step 3&4	Step 7	Step 9	Step 16

Case 3: Do not show `Close all tabs` warning dialog when the pref is `disabled` again OR `Don’t ask me again` check box is checked - PASSED

Continue from Case 2 (Pref is enabled)
Open multiple tabs
Leave the default selection for Continue where you left off in brave://settings/getStarted
Disable Warn me before closing window with multiple tabs pref in Help tips section of brave://settings
Close the browser window
Verified Close all tabs dialog not displayed
Relaunch the browser
All of the tabs are preserved
Enable the pref in the Help tips section of brave://settings
Close the browser window
Check the check box for Don’t ask me again
Click Close all button
Relaunch the browser
All tabs are preserved
Navigate to Help tips section of brave://settings
Verified Warn me before closing window with multiple tabs pref is disabled

Step2&3	Step4	Step11	Step14

Case 4: Test with `onbeforeunload` handler - PASSED

Launch Browser and set option is enabled
Create window and create more than one NTP tabs
Load https://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_onbeforeunload in one NTP and click Click here to go to w3schools.com and check beforeunload dialog is launched. Then, dismiss it.
Try to close window by clicking close button or window closing shortcut (alt + f4, or cmd+shift+w on macOS)
Select Close all and check beforeunload dialog is launched
Cancel beforeunload dialog
Repeat step 4 and check window Close all tabs is shown again
Select Close all and also Leave from beforeunload dialog and check window is closed

Step 1	Step2	Step3	Step4	Step5	Step7	Step8

Case 5: Test with download in-progress handler - PASSED

Fresh Install

Launch Browser and set option is enabled
Create window and create more than one NTP tabs
Load https://ubuntu.com/download/desktop/thank-you?version=22.04&architecture=amd64 and start download
Try to close window by clicking close button or window closing shortcut (alt + f4, or cmd+shift+w on macOS)
Select Close all from window-closing dialog and check Download in-progress warning dialog is launched
Select Continue downloading
Repeat step 4 and check window-closing dialog is launched again
Select Close all from window-closing dialog and select Exit from Download in-progress warning dialog
Check window is closed.

Ex1	Ex2	Ex3

Case 6: Test with onbeforeunload and download in-progress handler - PASSED

(Note: On macOS, download warning dialog is not shown on normal profile. Private window will have same behavior on macOS with other platform's normal window)

Fresh Install

Launch Browser and set option as enabled
Create window and create more than one NTP tabs
Load https://ubuntu.com/download/desktop/thank-you?version=22.04&architecture=amd64 and start download
Load https://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_onbeforeunload in one NTP and click Click here to go to w3schools.com and check beforeunload dialog is launched. Then, dismiss it.
Try to close window by clicking close button or window closing shortcut (alt + f4, or cmd+shift+w on macOS)
Check download warning or beforeunload dialog is launched one by one after selecting Close all from window closing dialog
Verified beforeunload dialog is launched after selecting Close All dialog

Ex1	Ex2	Ex3	Ex4	Ex5

Case 7: Test with reboot/restart - PASSED

Launch Browser and set option as enabled

Create window and create more than one NTP tabs

Load brave://restart and check-window closing dialog is not launched

Repeat step 1,2 and load brave://quitand check window-closing dialog is not launched

Verified Close all warning dialog is not launched for both restart and quit

Ex1	Ex2	Ex3

Case 8: Test with update - PASSED

Launch Browser and set option as enabled
Create window and more than one tab
Load brave://settings/help and wait until relaunch is ready after downloading new update
Click Relaunch button and check window-closing dialog is not launched
Verified Close all warning dialog is not launched upon update

Step1	Step3	Update

Case 9: Test with profile deletion - PASSED

Launch Browser and set option as enabled
Create window with more than one tabs
Delete active profile and check window closing confirm dialog is not launched.
Verified Close all warning dialog is not launched

Ex1	Ex2	Ex3	Ex4

Additional scenarios

Verified the Close all tabs warning dialog works as expected with Open the New Tab Page selection in brave://settings/getStarted
Verified the Close all tabs warning dialog works as expected with Open a specific page or set of pages selection in brave://settings/getStarted
Verified Close all tabs warning dialog works as expected with Private Browsing with Tor window
Verified Close all tabs warning dialog works as expected with Private window

Test Case II Upgrade:

Upgrade Test - PASSED

Install 1.39.x

Create window with than one tab

Help tips section in brave://settings do not have Warn me before closing window with multiple tabs pref

Load brave://settings/help and wait for updates to complete

Click to Relaunch the browser

Verified Warn me before closing window with multiple tabs pref is available and set to OFF as a default

Also confirmed successful upgrade to 1.40.80

Ex1	Ex2	Ex3	Ex4	Ex5

Verification passed on

Brave	1.40.87 Chromium: 102.0.5005.78 (Official Build) beta (64-bit)
Revision	df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS	Ubuntu 18.04 LTS

Case 1: `Warn me before closing window with multiple tab` preference is added in brave://settings/braveHelpTips and is `disabled` as a default - PASSED

Install 1.40.x
Launch brave
Open brave://settings>>click Additional settings>>click Help tips
Verified `Warn me before closing window with multiple tab’ pref is available
The toggle is OFF by default

Case 2: Basic Test- Show `Close all tabs` warning dialog upon closing multiple tabs, when the pref is `enabled` - PASSED

New profile
Launch brave
Create new window with multiple tabs
Leave the default selection for Continue where you left off in brave://settings/getStarted
Close the browser window ('x' or alt+f4)
Verified warning Close all tabs dialog is not launched since pref is OFF by default
Enable Warn me before closing window with multiple tabs in Help tips section of brave://settings
Close the browser window ('x' or alt+f4)
Verified Close all tabs dialog displayed with correct text
UI matched to figma
Click Cancel button
Warning dialog is dismissed
Close the browser window again ('x' or alt+f4)
Click Close all button in the Warning dialog
Relaunch the browser
All of the tabs are preserved

Case 3: Do not show `Close all tabs` warning dialog when the pref is `disabled` again OR `Don’t ask me again` check box is checked - PASSED

Continue from Case 2 (Pref is enabled)
Open multiple tabs
Leave the default selection for Continue where you left off in brave://settings/getStarted
Disable Warn me before closing window with multiple tabs pref in Help tips section of brave://settings
Close the browser window
Verified Close all tabs dialog not displayed
Relaunch the browser
All of the tabs are preserved
Enable the pref in the Help tips section of brave://settings
Close the browser window
Check the check box for Don’t ask me again
Click Close all button
Relaunch the browser
All tabs are preserved
Navigate to Help tips section of brave://settings
Verified Warn me before closing window with multiple tabs pref is disabled

Case 4: Test with `onbeforeunload` handler - PASSED

Launch Browser and set option is enabled
Create window and create more than one NTP tabs
Load https://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_onbeforeunload in one NTP and click Click here to go to w3schools.com and check beforeunload dialog is launched. Then, dismiss it.
Try to close window by clicking close button or window closing shortcut (alt + f4, or cmd+shift+w on macOS)
Select Close all and check beforeunload dialog is launched
Cancel beforeunload dialog
Repeat step 4 and check window Close all tabs is shown again
Select Close all and also Leave from beforeunload dialog and check window is closed

Case 5: Test with download in-progress handler - PASSED

Fresh Install

Launch Browser and set option is enabled
Create window and create more than one NTP tabs
Load https://ubuntu.com/download/desktop/thank-you?version=22.04&architecture=amd64 and start download
Try to close window by clicking close button or window closing shortcut (alt + f4, or cmd+shift+w on macOS)
Select Close all from window-closing dialog and check Download in-progress warning dialog is launched
Select Continue downloading
Repeat step 4 and check window-closing dialog is launched again
Select Close all from window-closing dialog and select Exit from Download in-progress warning dialog
Check window is closed.

Case 6: Test with onbeforeunload and download in-progress handler - PASSED

(Note: On macOS, download warning dialog is not shown on normal profile. Private window will have same behavior on macOS with other platform's normal window)

Fresh Install

Launch Browser and set option as enabled
Create window and create more than one NTP tabs
Load https://ubuntu.com/download/desktop/thank-you?version=22.04&architecture=amd64 and start download
Load https://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_onbeforeunload in one NTP and click Click here to go to w3schools.com and check beforeunload dialog is launched. Then, dismiss it.
Try to close window by clicking close button or window closing shortcut (alt + f4, or cmd+shift+w on macOS)
Check download warning or beforeunload dialog is launched one by one after selecting Close all from window closing dialog
Verified beforeunload dialog is launched after selecting Close All dialog

Case 7: Test with reboot/restart - PASSED

Launch Browser and set option as enabled

Create window and create more than one NTP tabs

Load brave://restart and check-window closing dialog is not launched

Repeat step 1,2 and load brave://quitand check window-closing dialog is not launched

Verified Close all warning dialog is not launched for both restart and quit

Case 8: Test with update - PASSED

Launch Browser and set option as enabled
Create window and more than one tab
Load brave://settings/help and wait until relaunch is ready after downloading new update
Click Relaunch button and check window-closing dialog is not launched
Verified Close all warning dialog is not launched upon update

Case 9: Test with profile deletion - PASSED

Launch Browser and set option as enabled
Create window with more than one tabs
Delete active profile and check window closing confirm dialog is not launched.
Verified Close all warning dialog is not launched

Additional scenarios

Verified the Close all tabs warning dialog works as expected with Open the New Tab Page selection in brave://settings/getStarted
Verified the Close all tabs warning dialog works as expected with Open a specific page or set of pages selection in brave://settings/getStarted
Verified Close all tabs warning dialog works as expected with Private Browsing with Tor window
Verified Close all tabs warning dialog works as expected with Private window

Test Case II Upgrade:

Upgrade Test - PASSED

Install 1.39.x

Create window with than one tab

Help tips section in brave://settings do not have Warn me before closing window with multiple tabs pref

Load brave://settings/help and wait for updates to complete

Click to Relaunch the browser

Verified Warn me before closing window with multiple tabs pref is available and set to OFF as a default

Also confirmed successful upgrade to 1.40.80

Brave-Matt added feature/global-settings Settings at browser level independent of shields settings feature-request OS/Desktop labels Jun 23, 2020

srirambv added OS/Linux OS/Windows labels Jun 24, 2020

rebron added priority/P4 Planned work. We expect to get to it "soon". design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Aug 14, 2020

rebron self-assigned this Aug 14, 2020

rebron removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Feb 24, 2021

simonhong added the QA/Yes label May 5, 2022

simonhong removed OS/Linux OS/macOS OS/Windows labels May 5, 2022

simonhong added the release-notes/include label May 7, 2022

rebron removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label May 10, 2022

GeetaSarvadnya mentioned this issue May 17, 2022

Upgrade from Chromium 101 to Chromium 102. #21976

Closed

stephendonner mentioned this issue May 23, 2022

Upgrade from Chromium 102.0.5005.50 to Chromium 102.0.5005.61. #22923

Closed

LaurenWags added the QA/Test-All-Platforms label May 24, 2022

MadhaviSeelam added QA Pass-Win64 and removed QA Pass-Win64 labels May 25, 2022

stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 1, 2022

stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 1, 2022

btlechowski added the QA Pass-Linux label Jun 13, 2022

kjozwiak mentioned this issue Jun 21, 2022

Desktop release notes for 1.40.x - Release #23566

Closed

rebron mentioned this issue Jun 23, 2022

Ask tough of the community : Reduce Crypto feature in update. #23642

Closed

mat926 mentioned this issue Jun 30, 2022

Add "warning/confirmation" dialog when choosing "Close other tabs" from the context menu #23782

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add "warning/confirmation" dialog when closing a window w/ multiple tabs #10430

Add "warning/confirmation" dialog when closing a window w/ multiple tabs #10430

Brave-Matt commented Jun 23, 2020 •

edited by rebron

Loading

srirambv commented Jun 24, 2020

AmbrocioIsaias2808 commented Jul 2, 2020 •

edited

Loading

joemamabuckeye commented Jul 8, 2020

srirambv commented Oct 2, 2020

ksalhab89 commented Nov 8, 2020

9codes commented Dec 6, 2020

9codes commented Dec 6, 2020 •

edited

Loading

bsclifton commented Dec 7, 2020

9codes commented Dec 13, 2020

murad-alm commented Feb 24, 2021

pes10k commented Feb 24, 2021

murad-alm commented Feb 24, 2021

pes10k commented Feb 24, 2021

murad-alm commented Feb 24, 2021 •

edited

Loading

bridiver commented Feb 24, 2021

murad-alm commented Feb 25, 2021

bridiver commented Feb 25, 2021

zcraber commented Feb 27, 2021

JakubBarta commented Mar 7, 2021

DutchPete commented May 5, 2022

simonhong commented May 5, 2022

MadhaviSeelam commented May 25, 2022 •

edited

Loading

DutchPete commented May 25, 2022

MadhaviSeelam commented May 25, 2022

stephendonner commented Jun 1, 2022 •

edited by btlechowski

Loading

Add "warning/confirmation" dialog when closing a window w/ multiple tabs #10430

Add "warning/confirmation" dialog when closing a window w/ multiple tabs #10430

Comments

Brave-Matt commented Jun 23, 2020 • edited by rebron Loading

Description

Designs

Assets

Miscellaneous Information:

srirambv commented Jun 24, 2020

AmbrocioIsaias2808 commented Jul 2, 2020 • edited Loading

joemamabuckeye commented Jul 8, 2020

srirambv commented Oct 2, 2020

ksalhab89 commented Nov 8, 2020

9codes commented Dec 6, 2020

9codes commented Dec 6, 2020 • edited Loading

bsclifton commented Dec 7, 2020

9codes commented Dec 13, 2020

murad-alm commented Feb 24, 2021

pes10k commented Feb 24, 2021

murad-alm commented Feb 24, 2021

pes10k commented Feb 24, 2021

murad-alm commented Feb 24, 2021 • edited Loading

bridiver commented Feb 24, 2021

murad-alm commented Feb 25, 2021

bridiver commented Feb 25, 2021

zcraber commented Feb 27, 2021

JakubBarta commented Mar 7, 2021

DutchPete commented May 5, 2022

simonhong commented May 5, 2022

MadhaviSeelam commented May 25, 2022 • edited Loading

DutchPete commented May 25, 2022

MadhaviSeelam commented May 25, 2022

stephendonner commented Jun 1, 2022 • edited by btlechowski Loading

Verification PASSED using

Brave-Matt commented Jun 23, 2020 •

edited by rebron

Loading

AmbrocioIsaias2808 commented Jul 2, 2020 •

edited

Loading

9codes commented Dec 6, 2020 •

edited

Loading

murad-alm commented Feb 24, 2021 •

edited

Loading

MadhaviSeelam commented May 25, 2022 •

edited

Loading

stephendonner commented Jun 1, 2022 •

edited by btlechowski

Loading

Verification `PASSED` using