Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 102.0.5005.50 to Chromium 102.0.5005.61. #22923

Closed
mkarolin opened this issue May 18, 2022 · 5 comments · Fixed by brave/brave-core#13379
Closed

Upgrade from Chromium 102.0.5005.50 to Chromium 102.0.5005.61. #22923

mkarolin opened this issue May 18, 2022 · 5 comments · Fixed by brave/brave-core#13379

Comments

@mkarolin
Copy link
Contributor

mkarolin commented May 18, 2022

Minor Chromium bump.

https://chromium.googlesource.com/chromium/src/+log/102.0.5005.50..102.0.5005.61?pretty=fuller&n=10000

QA tests:

Check branding items
Check for version bump

Additional checks:

  • Verify that the Rewards and Shields icons colors look correct in a new and an existing profile, with light and dark themes.
@kjozwiak
Copy link
Member

Just a heads up that macOS & Linux still need to quickly run through the affected area's mentioned via #21976 (comment). Other platforms can basically just make sure that the correct chromium version is being used 👍

@kjozwiak
Copy link
Member

kjozwiak commented May 23, 2022

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.39.111 Chromium: 102.0.5005.61 (Official Build) (64-bit)
--- | ---
Revision | 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS | Android 12; Build/SP1A.210812.016

Screenshot_20220523-114222_Brave

Verification PASSED on Samsung Galaxy Tablet A running Android 11 using the following build(s):

Brave | 1.39.111 Chromium: 102.0.5005.61 (Official Build) (64-bit)
--- | ---
Revision | 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS | Android 11; Build/RP1A.200720.012

Screenshot_20220523-114408_Brave

@MadhaviSeelam
Copy link

MadhaviSeelam commented May 23, 2022

Verification PASSED using

Brave | 1.39.111 Chromium: 102.0.5005.61 (Official Build) (64-bit)
-- | --
Revision | 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS | Windows 11 Version 21H2 (Build 22000.675)
  • Confirmed correct chromium version
  • Additional checks: Confirmed that the Rewards and Shields icons colors look correct in a new and an existing profile, with light and dark themes.
Version
Rewards-Dark Rewards-Light Shields-Dark Shields_Light
Rewards-dark Rewards-Light Shields-dark Shields-light

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 23, 2022
@stephendonner
Copy link

stephendonner commented May 23, 2022

Verification PASSED using

Brave 1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS macOS Version 11.6.6 (Build 20G624)
Confirmed correct Chromium version:

102.0.5005.61

Screen Shot 2022-05-23 at 2 27 15 PM
Chromium sidebar toolbar icon removed and reading list panel deactivated - PASSED
  • Confirmed side-panel flags is removed from brave://flags
  • Confirmed Reading-List panel is deactivated in clean profile
  • Confirmed enabling Reading-List panel in 1.40.22 and "upgrading" to 1.39.111 removed the feature, as expected
1.40.22 1.39.111
Screen Shot 2022-05-23 at 2 03 32 PM Screen Shot 2022-05-23 at 2 04 01 PM
brave://settings search box - PASSED
  • Confirmed that searching any string in the search box is working as expected
  • Confirmed that if search string is not found message is shown as expected
  • Confirmed that user can search a string using Command + F or click on the search icon in brave://settings
search result no result
Screen Shot 2022-05-23 at 10 31 06 AM Screen Shot 2022-05-23 at 10 31 17 AM
Component updater - PASSED
  • Confirmed new component Url Param Classifications is added in CR102
  • Clicked on Check for update and waited for 8 minutes; confirmed components are Up-to-date, Updated, or Component not updated. No errors.
default after 8 minutes
Screen Shot 2022-05-23 at 11 42 15 AM Screen Shot 2022-05-23 at 11 51 36 AM
Content-settings rules (adblock, permissions, etc.) - PASSED

Basic-functionality tested content-settings rules, using permission.site

  • confirmed various browser-session and time-based permission settings

Blocked elements on techcrunch.com, using brave://adblock

  • confirmed able to block elements using the UI
  • confirmed element markup appears in brave://adblock
  • confirmed clearing brave://adblock resets techcrunch.com rendering to default
example example example example
Screen Shot 2022-05-23 at 2 20 51 PM Screen Shot 2022-05-23 at 2 20 58 PM Screen Shot 2022-05-23 at 2 24 25 PM Screen Shot 2022-05-23 at 2 21 07 PM
Protocol handlers for IPFS/IPNS - PASSED
  • Confirmed IPFS and IPNS protocol handlers message is shown under Show connection details
  • Confirmed user can enable IPFS/IPNS via websites
  • Confirmed IPFS and IPNS work fine with various URIs
example example
Screen Shot 2022-05-23 at 11 32 55 AM Screen Shot 2022-05-23 at 11 30 29 AM

Components comparison - PASSED
  • Confirmed new component Url Param Classifications is added as part of CR102 and the old component Autofill Regex Data is removed from CR102
  • Confirmed components are up-to-date and version details are updated as expected
1.39.111 1.38.118
Screen Shot 2022-05-23 at 1 23 47 PM Screen Shot 2022-05-23 at 1 09 58 PM

Settings comparison - PASSED
Rewards and Shields icons/theming - PASSED
Rewards - Light Rewards - Dark Shields - Light Shields - Dark
Screen Shot 2022-05-23 at 1 36 49 PM Screen Shot 2022-05-23 at 1 37 12 PM Screen Shot 2022-05-23 at 1 42 05 PM Screen Shot 2022-05-23 at 1 39 33 PM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 23, 2022
@btlechowski
Copy link

btlechowski commented May 24, 2022

Verification passed on

Brave 1.39.111 Chromium: 102.0.5005.61 (Official Build) (64-bit)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS Ubuntu 18.04 LTS
Confirmed correct Chromium version:

102.0.5005.61

image

Chromium sidebar toolbar icon removed and reading list panel deactivated - PASSED
  • Confirmed side-panel flags is removed from brave://flags
  • Confirmed Reading-List panel is deactivated in clean profile
brave://settings search box - PASSED
  • Confirmed that searching any string in the search box is working as expected
  • Confirmed that if search string is not found message is shown as expected
  • Confirmed that user can search a string using Control + F or click on the search icon in brave://settings

image

Component updater - PASSED
  • Confirmed new component Url Param Classifications is added in CR102
  • Clicked on Check for update and waited for 8 minutes; confirmed components are Up-to-date, Updated, or Component not updated. No errors.

image
image

Content-settings rules (adblock, permissions, etc.) - PASSED

Basic-functionality tested content-settings rules, using permission.site

  • confirmed various browser-session and time-based permission settings

Blocked elements on techcrunch.com, using brave://adblock

  • confirmed able to block elements using the UI
  • confirmed element markup appears in brave://adblock
  • confirmed clearing brave://adblock resets techcrunch.com rendering to default

image

Protocol handlers for IPFS/IPNS - PASSED
  • Confirmed IPFS and IPNS protocol handlers message is shown under Show connection details
  • Confirmed user can enable IPFS/IPNS via websites
  • Confirmed IPFS and IPNS work fine with various URIs

image
image


Components comparison - PASSED
  • Confirmed new component Url Param Classifications is added as part of CR102 and the old component Autofill Regex Data is removed from CR102
  • Confirmed components are up-to-date and version details are updated as expected

Settings comparison - PASSED
  • Compared brave settings 1.29.111 with 1.38.118 and confirmed that one new setting is added as part of Brave
    • Warn me before closing window with multiple tabs - path brave://settings/braveHelpTips - - One existing settings is edited/updated - Show suggested sites in autocomplete suggestions
Rewards and Shields icons/theming - PASSED

image
image
image
image

avinassh pushed a commit to avinassh/brave-browser-hardening that referenced this issue May 29, 2022
 - Added Solana support for account creation, sending SOL and sending SPL tokens with Brave Wallet. ([#22348](brave/brave-browser#22348))
 - Added the ability to buy with Ramp using Brave Wallet. ([#21639](brave/brave-browser#21639))
 - Added JSONSanitizer to API helper requests for Brave Wallet. ([#21831](brave/brave-browser#21831))
 - Added Dapp UI for requesting a public key and for decrypting ciphers using Brave Wallet. ([#21177](brave/brave-browser#21177))
 - Added web3_clientVersion support for Brave Wallet. ([#19278](brave/brave-browser#19278))
 - Added the ability to allow users to search sites for RSS feeds for Brave News. ([#21768](brave/brave-browser#21768))
 - Added support for blob partitioning. ([#21746](brave/brave-browser#21746))
 - Added minimum macOS version for Sparkle update process. ([#22918](brave/brave-browser#22918))
 - [Security] Blocked "window.ethereum" completely in third party iframes. ([#22686](brave/brave-browser#22686))
 - [Security] Updated Brave Wallet panel to prominently display eTLD+1 as reported on HackerOne by renekroka. ([#21787](brave/brave-browser#21787))
 - [Security] Fixed incorrect origin being displayed in Brave Wallet when a spend approval is pending. ([#19557](brave/brave-browser#19557))
 - Implemented eth_getEncryptionPublicKey for Brave Wallet. ([#19276](brave/brave-browser#19276))
 - Implemented account discovery when restoring Brave Wallet. ([#18104](brave/brave-browser#18104))
 - Updated Omaha installer version for Windows to v1.3.36.113. ([#22060](brave/brave-browser#22060))
 - Updated default IPFS configuration values. ([#22068](brave/brave-browser#22068))
 - Updated Gas Limit validation and error messaging for unapproved transactions with Brave Wallet. ([#21714](brave/brave-browser#21714))
 - Updated Brave Wallet to automatically add swap taker asset to the visible asset list. ([#21428](brave/brave-browser#21428))
 - Updated Brave Wallet portfolio network filter for multichain support. ([#20780](brave/brave-browser#20780))
 - Reduced adblock filter memory usage by optimizing unused regex rules. ([#21970](brave/brave-browser#21970))
 - Removed known Dialog Insight user tracking parameters from URLs. ([#22082](brave/brave-browser#22082))
 - Removed ability to swap ERC721 tokens with Brave Wallet. ([#21550](brave/brave-browser#21550))
 - Fixed crash which occurred when opening Brave Shields while using Google Meet. ([#22814](brave/brave-browser#22814))
 - Fixed inability to rename Solana account in Brave Wallet after it has been created. ([#22958](brave/brave-browser#22958))
 - Fixed incorrectly computed insufficient funds errors in Brave Wallet. ([#22877](brave/brave-browser#22877))
 - Fixed ERC20 and ERC721 transfers being incorrectly displayed as ETH transfers in the Brave Wallet transactions panel. ([#22044](brave/brave-browser#22044))
 - Fixed text alignment issues under the Brave Wallet "Recent transactions" panel when using long account names. ([#21216](brave/brave-browser#21216))
 - Fixed breakage in webpack build caused by OpenSSL 3.0. ([#22305](brave/brave-browser#22305))
 - Fixed two windows being opened on launch when the browser was installed without administrator privileges on Windows. ([#22179](brave/brave-browser#22179))
 - Upgraded Chromium to 102.0.5005.61. ([#22923](brave/brave-browser#22923)) ([Changelog for 102.0.5005.61](https://chromium.googlesource.com/chromium/src/+log/101.0.4951.67..102.0.5005.61?pretty=fuller&n=1000))
avinassh pushed a commit to avinassh/brave-browser-hardening that referenced this issue May 29, 2022
 - Added Brave Firewall + VPN. ([#12197](brave/brave-browser#12197))
 - Added support for blob partitioning. ([#21746](brave/brave-browser#21746))
 - Implemented eth_getEncryptionPublicKey for Brave Wallet. ([#19276](brave/brave-browser#19276))
 - Reduced adblock filter memory usage by optimizing unused regex rules. ([#21970](brave/brave-browser#21970))
 - Removed known Dialog Insight user tracking parameters from URLs. ([#22082](brave/brave-browser#22082))
 - Fixed breakage in webpack build caused by OpenSSL 3.0. ([#22305](brave/brave-browser#22305))
 - Fixed pending bell icon under Brave Wallet not being displayed when new unapproved requests are created. ([#21654](brave/brave-browser#21654))
 - Fixed expand icon under Brave Shields using incorrect color when the Privacy Hub has been enabled. ([#22049](brave/brave-browser#22049))
 - Upgraded Chromium to 102.0.5005.61. ([#22923](brave/brave-browser#22923)) ([Changelog for 102.0.5005.61](https://chromium.googlesource.com/chromium/src/+log/101.0.4951.67..102.0.5005.61?pretty=fuller&n=1000))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment