-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect CAPTCHA drag image on scaled Linux display #13072
Conversation
@tmancey mentioned recently that this is no longer a high priority as every 2 hours we fetch new token issuers and when we fetch these we refill tokens. |
A Storybook has been deployed to preview UI for the latest push |
// image offset when initiating the drag | ||
// See https://bugs.chromium.org/p/chromium/issues/detail?id=1297990 | ||
if (window.navigator.userAgent.includes('Linux') && devicePixelRatio > 1) { | ||
event.dataTransfer.setDragImage( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think this is this something that will break the captcha (for this subset of users) when the upstream bug is fixed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's possible, unfortunately, depending on how https://bugs.chromium.org/p/chromium/issues/detail?id=1297990 is ultiumately addressed. I tried to limit the impact as much as possible with the platform and devicePixelRatio
guards. I feel like any workaround we implement will have to be removed and uplifted once the upstream bug is fixed. Definitely open to other approaches though!
fa8988d
to
5dcc19f
Compare
A Storybook has been deployed to preview UI for the latest push |
CI passed on all platforms but Windows; restarting on Windows. |
CI passed; ready to merge. |
Verification PASSED on
As per #13072 (comment), went through several different scales on
Verification PASSED on
Verification PASSED on
Used the
|
Resolves brave/brave-browser#22180
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
We should also test this on Mac and Windows at various resolutions, although there should be no changes on either of those platforms as this fix is scoped to Linux systems running with scaled displays.