Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't apply whitelist if font family is generic #13205

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Don't apply whitelist if font family is generic #13205

merged 1 commit into from
Apr 28, 2022

Conversation

pilgrim-brave
Copy link
Contributor

Resolves brave/brave-browser#22605

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@pilgrim-brave pilgrim-brave requested a review from a team as a code owner April 28, 2022 16:20
@pilgrim-brave pilgrim-brave changed the title Don't apply whitelist to if font family is generic Don't apply whitelist if font family is generic Apr 28, 2022
@pilgrim-brave pilgrim-brave self-assigned this Apr 28, 2022
@pilgrim-brave pilgrim-brave added this to the 1.40.x - Nightly milestone Apr 28, 2022
mkarolin
mkarolin approved these changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src ++

@pilgrim-brave pilgrim-brave merged commit cfe1d7e into master Apr 28, 2022
@pilgrim-brave pilgrim-brave deleted the mpilgrim_font_whitelist_generic branch April 28, 2022 19:01
@pilgrim-brave pilgrim-brave restored the mpilgrim_font_whitelist_generic branch May 27, 2022 15:13
bsclifton pushed a commit that referenced this pull request May 31, 2022
@pilgrim-brave @bsclifton
Don't apply whitelist to if font family is generic (#13205)
f0261a0
@bsclifton bsclifton mentioned this pull request May 31, 2022
Merged
7 tasks
@bsclifton bsclifton deleted the mpilgrim_font_whitelist_generic branch May 31, 2022 22:12
bsclifton added a commit that referenced this pull request Jun 22, 2022
@bsclifton
Revert Implement "reduce language fingerprinting' and follow ups
10ed0c2 
Fixes brave/brave-browser#23093

Unfixes brave/brave-browser#20096
Unfixes brave/brave-browser#816

Reverts #13807
Which fixed brave/brave-browser#23489

Reverts #13205
Which fixed brave/brave-browser#22605

Reverts #12234
Which fixed brave/brave-browser#20096 and brave/brave-browser#816
bsclifton added a commit that referenced this pull request Jun 22, 2022
@bsclifton
Revert Implement "reduce language fingerprinting' and follow ups
7177a3e 
Fixes brave/brave-browser#23093

Unfixes brave/brave-browser#20096
Unfixes brave/brave-browser#816

Reverts #13807
Which fixed brave/brave-browser#23489

Reverts #13205
Which fixed brave/brave-browser#22605

Reverts #12234
Which fixed brave/brave-browser#20096 and brave/brave-browser#816
@bsclifton bsclifton mentioned this pull request Jun 22, 2022
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkarolin mkarolin mkarolin approved these changes

Assignees

@pilgrim-brave pilgrim-brave

Labels
None yet
Projects
None yet
Milestone
1.40.x - Release
Development

Successfully merging this pull request may close these issues.

Apple Music has improper font spacing
2 participants
@pilgrim-brave @mkarolin