Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't apply whitelist if font family is generic (Uplift to 1.39.x) #13550

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Don't apply whitelist if font family is generic (Uplift to 1.39.x) #13550

merged 1 commit into from
Jun 2, 2022

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented May 31, 2022 •
edited by kjozwiak
Loading

Manual uplift of #13205
Resolves brave/brave-browser#22605

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bsclifton bsclifton added this to the 1.39.x - Release #3 milestone May 31, 2022
@bsclifton bsclifton requested a review from a team May 31, 2022 22:12
@bsclifton bsclifton requested a review from a team as a code owner May 31, 2022 22:12
@bsclifton bsclifton self-assigned this May 31, 2022
@bsclifton bsclifton removed the request for review from a team May 31, 2022 22:12
kjozwiak
kjozwiak approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.39.x approved 👍 QA has verified the PR on BETA as per brave/brave-browser#22605 (comment).

@kjozwiak kjozwiak merged commit f4d7467 into 1.39.x Jun 2, 2022
@kjozwiak kjozwiak deleted the mpilgrim_font_whitelist_generic-1.39.x branch June 2, 2022 06:34
@kjozwiak kjozwiak mentioned this pull request Jun 2, 2022
Closed
@bsclifton bsclifton mentioned this pull request Jun 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
1.39.x - Release #3
Development

Successfully merging this pull request may close these issues.
3 participants
@bsclifton @kjozwiak @pilgrim-brave