Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes publisher not showing in the panel if ac off #1336

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 14, 2019

Resolves brave/brave-browser#2084

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • enable rewards
  • disable ac
  • visit verified site, unverified site and youtube video
  • make sure that for all sites above correct data is shown in the panel

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc merged commit cbf117b into master Jan 14, 2019
@NejcZdovc NejcZdovc deleted the disabled-ac branch January 14, 2019 20:26
NejcZdovc added a commit that referenced this pull request Jan 14, 2019
Fixes publisher not showing in the panel if ac off
NejcZdovc added a commit that referenced this pull request Jan 14, 2019
Fixes publisher not showing in the panel if ac off
@bbondy bbondy added this to the 0.61.x - Nightly milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disabling auto-contribution doesn't show YT publishers in Rewards panel
3 participants