Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes publisher not showing in the panel if ac off #1343

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Fixes publisher not showing in the panel if ac off #1343

merged 1 commit into from
Jan 15, 2019

Conversation

NejcZdovc
Copy link
Contributor

Original PR: #1336

Resolves brave/brave-browser#2084

@NejcZdovc
Merge pull request #1336 from brave/disabled-ac
bc0c876 
Fixes publisher not showing in the panel if ac off
@NejcZdovc NejcZdovc self-assigned this Jan 14, 2019
@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
@bbondy bbondy removed the 0.59.x label Jan 14, 2019
kjozwiak
kjozwiak approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 0.59.x approved after deliberating with @srirambv 👍 Please make sure that all associated issue(s) are also moved into the correct milestone.

@NejcZdovc NejcZdovc merged commit f835d6b into 0.59.x Jan 15, 2019
@NejcZdovc NejcZdovc deleted the disabled-ac-59 branch January 15, 2019 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@bsclifton bsclifton Awaiting requested review from bsclifton

@rebron rebron Awaiting requested review from rebron

@srirambv srirambv Awaiting requested review from srirambv

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.59.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@NejcZdovc @kjozwiak @bbondy