Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for several strings remain untranslated #1366

Merged
merged 5 commits into from
Jan 17, 2019
Merged

Fixes for several strings remain untranslated #1366

merged 5 commits into from
Jan 17, 2019

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jan 17, 2019 •
edited by simonhong
Loading

Fix brave/brave-browser#2831
Fix brave/brave-browser#2868

Review per commit is best.
This fixes 2 main problems with localization:

  1. Sometimes strings have the same ID for mac and non-mac using title case and not title case. This will translate both now like Chrome does.
  2. Chrome considers the meaning attribute for the fingerprint lookup to find localizations.

Before this PR about 20% of the strings were not localized.
15% of the strings were fixed after 1) above.
The other 5% fixed after 2) above.

This also updates strings.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bbondy bbondy added this to the 0.61.x - Nightly milestone Jan 17, 2019
@bbondy bbondy self-assigned this Jan 17, 2019
@bbondy bbondy requested a review from emerick January 17, 2019 03:33
@bbondy bbondy changed the title L10n fix Fixes for several strings remain untranslated Jan 17, 2019
This was referenced Jan 17, 2019
Merged
Merged
simonhong
simonhong reviewed Jan 17, 2019
View reviewed changes
app/resources/brave_generated_resources_ko.xtb Outdated
<translation id="7942180974165298215">Brave 광고 차단</translation>
<translation id="6406506848690869874">Brave 동기화</translation>
<translation id="6406506848690869874">동기화</translation>
<translation id="120759863357279975"><ph name="EXTENSION_NAME">$1</ph> (extension ID "<ph name="EXTENSION_ID">$2<ex>abacabadabacabaeabacabadabacabaf</ex></ph>")은(는) Brave에서 허용되지 않습니다.</translation>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recently, I added suggestions for korean translation bug(brave/brave-browser#2868) in transifex.com.
I assume that isn't accepted and not updated yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings were added in, thx.

@simonhong
Copy link
Member

Modified description to add Fix https://github.com/brave/brave-browser/issues/2868

emerick
emerick previously approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbondy bbondy merged commit 51c99cd into master Jan 17, 2019
@bsclifton bsclifton deleted the l10n-fix branch January 24, 2019 21:14
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@bbondy
Merge pull request #1366 from srirambv/template_update
aa3df58 
Add details to reproducible sections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonhong simonhong simonhong left review comments

@emerick emerick emerick left review comments

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
0.61.x - Release
Development

Successfully merging this pull request may close these issues.

Same strings are displayed twice in some UI in korean locale Several Strings Remain Untranslated
3 participants
@bbondy @simonhong @emerick