Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add window.phantom.solana alias #14282

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Add window.phantom.solana alias #14282

merged 2 commits into from
Jul 22, 2022

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Jul 21, 2022

Resolves brave/brave-browser#24192

doc update: brave/brave-wallet-docs#67

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Adapter

  1. Navigate to https://solana-labs.github.io/wallet-adapter/example/
  2. Click "Select Wallet" and choose Phantom
  3. Click "Connect"
  4. Should be able to prompt for granting permission.

OpenSea

  1. Navigate to https://opensea.io/
  2. Click Wallet icon and select Phantom
  3. Should be able to prompt for granting permission.

@darkdh darkdh requested a review from bbondy July 21, 2022 17:53
@darkdh darkdh requested a review from a team as a code owner July 21, 2022 17:53
@darkdh darkdh self-assigned this Jul 21, 2022
@darkdh darkdh force-pushed the new-phantom-provider branch from 579c55d to caad428 Compare July 21, 2022 19:51
@darkdh darkdh merged commit ca19446 into master Jul 22, 2022
@darkdh darkdh deleted the new-phantom-provider branch July 22, 2022 03:47
@github-actions github-actions bot added this to the 1.43.x - Nightly milestone Jul 22, 2022
darkdh added a commit that referenced this pull request Jul 22, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.44.3 Chromium: 104.0.5112.57 (Official Build) nightly (64-bit)
Revision 212fd173a0da1e0a024f328295bb56a2529190bb-refs/branch-heads/5112@{#1042}
OS Windows 11 Version 21H2 (Build 22000.795)
  • Verified steps from PR description
  • Verified able to prompt for granting permission when selecting Phantom as wallet provider on Dapps
Adapter OpenSea
14282-Adapter.mp4
14282-OpenSea.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phantom uses new provider object
3 participants