Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phantom uses new provider object #24192

Closed
darkdh opened this issue Jul 21, 2022 · 5 comments · Fixed by brave/brave-core#14282
Closed

Phantom uses new provider object #24192

darkdh opened this issue Jul 21, 2022 · 5 comments · Fixed by brave/brave-core#14282
Assignees
@darkdh
Labels
closed/wontfix feature/web3/wallet/dapps feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop

Comments

@darkdh
Copy link
Member

darkdh commented Jul 21, 2022 •
edited
Loading

They use window.phantom.solana and keep window.solana for legacy integration
https://docs.phantom.app/integrating/extension-and-in-app-browser-web-apps/detecting-the-provider
Also updated in wallet-adapter
anza-xyz/wallet-adapter@05df190

We need to support that because no every websites using wallet-adapter would list us so users have to way to interact with brave wallet for those dapps sites. (Ex. https://opensea.io/)
@darkdh darkdh added priority/P2 A bad problem. We might uplift this to the next planned release. OS/Desktop feature/web3/wallet/solana feature/web3/wallet/dapps labels Jul 21, 2022
@darkdh darkdh self-assigned this Jul 21, 2022
@darkdh darkdh added this to Web3 Jul 21, 2022
@darkdh darkdh moved this to In Progress in Web3 Jul 21, 2022
@darkdh darkdh mentioned this issue Jul 21, 2022
Merged
25 tasks
@darkdh darkdh moved this from In Progress to In Review in Web3 Jul 21, 2022
Repository owner moved this from In Review to Done in Web3 Jul 22, 2022
@brave-builds brave-builds added this to the 1.43.x - Nightly milestone Jul 22, 2022
@darkdh darkdh mentioned this issue Jul 22, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.42.81 or higher for 1.42.x verification 👍

@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Jul 28, 2022
@srirambv

This comment was marked as outdated.

Sign in to view
@bsclifton bsclifton mentioned this issue Aug 2, 2022
Closed
25 tasks
bsclifton added a commit to brave/brave-core that referenced this issue Aug 2, 2022
@bsclifton
Remove window.phantom alias
ad9fa96 
Reverts #14282

Fixes brave/brave-browser#24289
Unfixes brave/brave-browser#24192
@bbondy
Copy link
Member

bbondy commented Aug 2, 2022

I think we should change this one to exclude now since we're going to not include window.phantom because of the webcompat issues.

@darkdh
Copy link
Member Author

darkdh commented Aug 2, 2022

reverted through
1.44.x brave/brave-core#14430
1.43.x brave/brave-core#14432
1.42.x brave/brave-core#14433

and waiting for Phantom to update new provider object other than window.phantom so we can follow.

@darkdh darkdh reopened this Aug 2, 2022
@darkdh darkdh moved this from Done to Backlog in Web3 Aug 2, 2022
@darkdh darkdh removed this from the 1.42.x - Release milestone Aug 2, 2022
@darkdh
Copy link
Member Author

darkdh commented Aug 5, 2022

we don't need this anymore because now wallet adapter has fallback

@darkdh darkdh closed this as completed Aug 5, 2022
Repository owner moved this from Backlog to Done in Web3 Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
closed/wontfix feature/web3/wallet/dapps feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop
Projects
Web3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add window.phantom.solana alias brave/brave-core
6 participants
@bbondy @kjozwiak @darkdh @srirambv @LaurenWags @brave-builds