Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add window.phantom.solana alias" (uplift to 1.42.x) #14433

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Revert "Add window.phantom.solana alias" (uplift to 1.42.x) #14433

merged 1 commit into from
Aug 2, 2022

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Aug 2, 2022 •
edited by bsclifton
Loading

Uplift of #14430
Resolves brave/brave-browser#24289

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@darkdh darkdh requested a review from a team as a code owner August 2, 2022 17:07
@darkdh darkdh mentioned this pull request Aug 2, 2022
Closed
@bsclifton bsclifton added this to the 1.42.x - Release milestone Aug 2, 2022
bsclifton
bsclifton approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 41779cb into 1.42.x Aug 2, 2022
@bsclifton bsclifton deleted the pr14430_revert-window-phantom_1.42.x branch August 2, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@darkdh darkdh

Labels
None yet
Projects
None yet
Milestone
1.42.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@darkdh @bsclifton @brave-browser-releases