Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[translate] Stop checking Google Translate Extension #15110

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m commented Sep 15, 2022

Resolves brave/brave-browser#24715

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@atuchin-m atuchin-m requested a review from a team as a code owner September 15, 2022 15:36
@atuchin-m atuchin-m self-assigned this Sep 15, 2022
@atuchin-m atuchin-m force-pushed the stop-checking-google-translate branch from e35846d to 55cbd88 Compare September 19, 2022 12:11
@atuchin-m atuchin-m merged commit 358eb88 into master Sep 29, 2022
@atuchin-m atuchin-m deleted the stop-checking-google-translate branch September 29, 2022 12:23
@github-actions github-actions bot added this to the 1.46.x - Nightly milestone Sep 29, 2022
@atuchin-m atuchin-m restored the stop-checking-google-translate branch November 9, 2022 15:46
atuchin-m added a commit that referenced this pull request Nov 10, 2022
* [translate] Stop checking Google Translate Extension
* Fix compilation
kjozwiak added a commit that referenced this pull request Nov 10, 2022
…nslate_1.45.x

[translate] Stop checking Google Translate Extension (#15110)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants