Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[translate] Stop checking Google Translate Extension (#15110) #15888

Merged
merged 1 commit into from
Nov 10, 2022
Merged

[translate] Stop checking Google Translate Extension (#15110) #15888

merged 1 commit into from
Nov 10, 2022

Conversation

atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m commented Nov 10, 2022 •
edited by kjozwiak
Loading

Uplift of #15110
For brave/brave-browser#24715

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@atuchin-m
[translate] Stop checking Google Translate Extension (#15110)
e9c3210 
* [translate] Stop checking Google Translate Extension
* Fix compilation
@atuchin-m atuchin-m requested a review from a team as a code owner November 10, 2022 16:12
@atuchin-m atuchin-m self-assigned this Nov 10, 2022
@kjozwiak kjozwiak added this to the 1.45.x - Release #7 milestone Nov 10, 2022
kjozwiak
kjozwiak approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.45.x approved 👍 QA has verified the PR on Nightly as per brave/brave-browser#24715 (comment).

@kjozwiak kjozwiak merged commit 3621c02 into 1.45.x Nov 10, 2022
@kjozwiak kjozwiak deleted the pr15110_stop-checking-google-translate_1.45.x branch November 10, 2022 18:41
@kjozwiak kjozwiak mentioned this pull request Nov 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@iefremov iefremov Awaiting requested review from iefremov

@rebron rebron Awaiting requested review from rebron

Assignees

@atuchin-m atuchin-m

Labels
None yet
Projects
None yet
Milestone
1.45.x - Release #7
Development

Successfully merging this pull request may close these issues.
2 participants
@atuchin-m @kjozwiak