Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create default solana acc when create\restore the wallet #15125

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Conversation

cypt4
Copy link
Collaborator

@cypt4 cypt4 commented Sep 16, 2022

Resolves brave/brave-browser#25432

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

For desktop, android and ios:
Enable BraveWalletSolana feature with create-default-solana-account = true
On android and desktop:

  1. Create new wallet and check that Solana acc is created, default coin is Solana, and default network is Solana mainnet beta.
  2. Restore wallet and check same conditions.
  3. Check lock& restore case.
  4. Check that if wallet was created before the update, solana won't be choosed as default and no solana account won't be created after the update.
    Enable BraveWalletSolana feature with create-default-solana-account = false
  5. Check that there is no solana acc after wallet creation&restoration

@cypt4 cypt4 requested a review from a team as a code owner September 16, 2022 19:22
@cypt4 cypt4 force-pushed the brave_25432 branch 2 times, most recently from b855ada to 1220d47 Compare September 16, 2022 19:31
@yrliou
Copy link
Member

yrliou commented Sep 16, 2022

FYI, I saw there are test failures in solana_provider_browsertest.cc, you probably need to adjust the feature param there too as that file assumes no solana accounts were created.

@yrliou yrliou requested a review from darkdh September 16, 2022 20:50
@cypt4 cypt4 force-pushed the brave_25432 branch 3 times, most recently from f30378e to e4bffa1 Compare September 19, 2022 10:08
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cypt4 cypt4 merged commit c76108b into master Sep 19, 2022
@cypt4 cypt4 deleted the brave_25432 branch September 19, 2022 19:36
@github-actions github-actions bot added this to the 1.45.x - Nightly milestone Sep 19, 2022
@srirambv
Copy link
Contributor

srirambv commented Sep 20, 2022

Verification passed on

Brave 1.45.62 Chromium: 106.0.5249.40 (Official Build) nightly (64-bit)
Revision fab1d91915d2722d6339aaa7f4e9ce44f1e9b103-refs/branch-heads/5249@{#442}
OS Windows 11 Version 21H2 (Build 22000.978)
  • Verified steps from PR
  • Verified Solana network is set as active network for new wallet or restored wallet
  • Verified first Solana account generated for the seed is set as the active account for new wallet or restored wallet
  • Verified on upgrade from previous build, Solana isn't set as active network
  • Verified on upgrade from previous build with Solana account created doesn't make it the active account unless it was set as active before upgrade
  • Encountered Tooltips are not correctly shown brave-browser#25495
15125.mp4

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 12 running 1.45.64 x64 build

  • Verified steps from PR
  • Verified Solana network is set as active network for new wallet or restored wallet
  • Verified first Solana account generated for the seed is set as the active account for new wallet or restored wallet
  • Verified on upgrade from previous build, Solana isn't set as active network
  • Verified on upgrade from previous build with Solana account created doesn't make it the active account unless it was set as active before upgrade
  • Verified no crash when creating new wallet
  • Verified Solana account is selected after account creation
15125-ARM.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Solana account and make Solana the default network for new wallet installs
4 participants