-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create default solana acc when create\restore the wallet #15125
Conversation
b855ada
to
1220d47
Compare
FYI, I saw there are test failures in solana_provider_browsertest.cc, you probably need to adjust the feature param there too as that file assumes no solana accounts were created. |
f30378e
to
e4bffa1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Verification passed on
15125.mp4 |
Verification passed on Oppo Reno 5 with Android 12 running 1.45.64 x64 build
15125-ARM.mp4 |
Resolves brave/brave-browser#25432
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
For desktop, android and ios:
Enable BraveWalletSolana feature with create-default-solana-account = true
On android and desktop:
Enable BraveWalletSolana feature with create-default-solana-account = false