Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create default solana acc when create\restore the wallet (Uplift to 1.44.x) #15135

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Create default solana acc when create\restore the wallet (Uplift to 1.44.x) #15135

merged 2 commits into from
Sep 20, 2022

Conversation

cypt4
Copy link
Collaborator

@cypt4 cypt4 commented Sep 19, 2022 •
edited by kjozwiak
Loading

Uplift of #15125 (And also of #14940 to solve conflicts)
Resolves brave/brave-browser#25432
Resolves brave/brave-browser#24800

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@cypt4 cypt4 requested a review from a team as a code owner September 19, 2022 20:01
@cypt4 cypt4 changed the title Select default account when create or restore wallet (Uplift to 1.44.x) Create default solana acc when create\restore the wallet (Uplift to 1.44.x) Sep 20, 2022
@kjozwiak kjozwiak added this to the 1.44.x - Beta milestone Sep 20, 2022
kjozwiak
kjozwiak approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.44.x approved 👍 QA has verified the PR on Nightly as per #15125 (comment) & #15125 (comment).

@kjozwiak kjozwiak merged commit c4a9a21 into 1.44.x Sep 20, 2022
@kjozwiak kjozwiak deleted the brave_25432_1.44.x_uplift branch September 20, 2022 21:52
@nuo-xu nuo-xu mentioned this pull request Sep 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@cypt4 cypt4

Labels
None yet
Projects
None yet
Milestone
1.44.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@cypt4 @kjozwiak