Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Verify Solana Account Creation for New Wallet #6044

Closed
nuo-xu opened this issue Sep 21, 2022 · 1 comment · Fixed by #6045
Closed

Verify Solana Account Creation for New Wallet #6044

nuo-xu opened this issue Sep 21, 2022 · 1 comment · Fixed by #6045

Comments

@nuo-xu
Copy link
Contributor

nuo-xu commented Sep 21, 2022

Since this Core has uplifted this change to 1.44 brave/brave-core#15135, we will need to verify Solana Account will be created when a new wallet is set up.

Steps:

  1. Create new wallet and check that Solana acc is created, default coin is Solana, and default network is Solana mainnet beta.
  2. Restore wallet and check same conditions.
  3. Check lock& restore case.
  4. Check that if wallet was created before the update, solana won't be choosed as default and no solana account won't be created after the update.
@nuo-xu nuo-xu added this to the 1.44 milestone Sep 21, 2022
@StephenHeaps StephenHeaps self-assigned this Sep 21, 2022
StephenHeaps added a commit that referenced this issue Sep 21, 2022
Fix possible infinite loop when restoring wallet
@srirambv
Copy link
Contributor

srirambv commented Oct 3, 2022

Verification passed on iPhone 7+ with iOS 14.8.1 running 1.44 (22.9.29.15)

  • Verified steps from issue description and #6045
  • Verified creating a new wallet automatically creates Solana account
  • Verified restoring wallet from seed works fine and app doesn't go into infinite loop

Verification passed on iPhone XR with iOS 15.6.1 running 1.44 (22.9.29.15)

  • Verified steps from issue description and #6045
  • Verified creating a new wallet automatically creates Solana account
  • Verified restoring wallet from seed works fine and app doesn't go into infinite loop

Verification passed on iPad Pro with iOS 16.1 running 1.44 (22.9.29.15)

  • Verified steps from issue description and #6045
  • Verified creating a new wallet automatically creates Solana account
  • Verified restoring wallet from seed works fine and app doesn't go into infinite loop

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.