Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After wallet restoration the getSelectedAccount(CoinType.ETH) returns null (Brave-Core) #24800

Closed
Pavneet-Sing opened this issue Aug 19, 2022 · 5 comments · Fixed by brave/brave-core#14940
Closed

After wallet restoration the getSelectedAccount(CoinType.ETH) returns null (Brave-Core) #24800

Pavneet-Sing opened this issue Aug 19, 2022 · 5 comments · Fixed by brave/brave-core#14940
Assignees
@cypt4
Labels
dev-concern feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
1.44.x - Release

Comments

@Pavneet-Sing
Copy link

Description

After creating a new wallet or restoring wallet getSelectedAccount(CoinType.ETH,.... is returning null, causes unexpected behaviour while showing pending transaction for default accounts per coin.

Steps to reproduce

  1. Create or restore wallet
  2. Check return value of getSelectedAccount for ETH

Actual result

getSelectedAccount for ETH returns null

Expected result

the first auto created Ethereum account should be the selected account for ETH coin type

Issue reproduces how often

easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? y
  • Can you reproduce this issue with the current Play Store Beta version? y
  • Can you reproduce this issue with the current Play Store Nightly version? y
@Pavneet-Sing Pavneet-Sing added QA/No release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Aug 19, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Aug 19, 2022
@darkdh
Copy link
Member

darkdh commented Aug 19, 2022

This should be already fixed by brave/brave-core#14135
cc @cypt4

@Pavneet-Sing
Copy link
Author

Pavneet-Sing commented Aug 22, 2022 •
edited
Loading

@darkdh I have been debugging and testing this from some days past week, getting null after restoring wallet or creating a new wallet.

@Pavneet-Sing Pavneet-Sing removed their assignment Aug 24, 2022
@Pavneet-Sing Pavneet-Sing changed the title After wallet restoration the getSelectedAccount(CoinType.ETH) returns null After wallet restoration the getSelectedAccount(CoinType.ETH) returns null (Brave-Core) Aug 24, 2022
@Pavneet-Sing
Copy link
Author

FYI: I have created a separate issue to handle this manually on android : #24929

@cypt4 cypt4 self-assigned this Aug 31, 2022
@cypt4 cypt4 mentioned this issue Sep 1, 2022
Merged
25 tasks
cypt4 added a commit to brave/brave-core that referenced this issue Sep 13, 2022
@cypt4
Select default account when create or restore wallet
3d3cb56 
Resolves brave/brave-browser#24800
@cypt4 cypt4 added QA/Yes and removed QA/No labels Sep 14, 2022
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Sep 14, 2022
cypt4 added a commit to brave/brave-core that referenced this issue Sep 19, 2022
@cypt4
Select default account when create or restore wallet
826bdff 
Resolves brave/brave-browser#24800
@cypt4 cypt4 mentioned this issue Sep 19, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.44.95 or higher for 1.44.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 12 running 1.44.97 x64 build

  • Verified steps from brave/brave-core#14940
  • Verified no crash when creating account or restoring account
  • Verified when creating a new account Solana account is created and selected as default
  • Verified when restoring wallet via seed, first Solana account generate via the seed is restored and set as active network

Verification passed on Samsung Tab A with Android 10 running 1.44.97 x64 build

  • Verified steps from brave/brave-core#14940
  • Verified no crash when creating account or restoring account
  • Verified when creating a new account Solana account is created and selected as default
  • Verified when restoring wallet via seed, first Solana account generate via the seed is restored and set as active network

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
dev-concern feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.44.x - Release
Development

Successfully merging a pull request may close this issue.

Select default account when create or restore wallet brave/brave-core
6 participants
@kjozwiak @darkdh @Pavneet-Sing @srirambv @brave-builds @cypt4