Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select default account when create or restore wallet #14940

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Select default account when create or restore wallet #14940

merged 1 commit into from
Sep 14, 2022

Conversation

cypt4
Copy link
Collaborator

@cypt4 cypt4 commented Sep 1, 2022 •
edited
Loading

Resolves brave/brave-browser#24800

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Test account create & restore - no crashes and default account is selected.

@cypt4 cypt4 requested a review from a team as a code owner September 1, 2022 07:49
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Sep 1, 2022
@cypt4 cypt4 force-pushed the brave_24800 branch 2 times, most recently from 96fb95f to 64b6df8 Compare September 1, 2022 08:03
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@cypt4 cypt4 changed the title Brave 24800 Select default account when create or restore wallet Sep 1, 2022
@cypt4 cypt4 requested a review from darkdh September 5, 2022 12:37
darkdh
darkdh approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

1 similar comment
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@cypt4 cypt4 merged commit 1ef83de into master Sep 14, 2022
@cypt4 cypt4 deleted the brave_24800 branch September 14, 2022 08:52
@github-actions github-actions bot added this to the 1.45.x - Nightly milestone Sep 14, 2022
@cypt4 cypt4 mentioned this pull request Sep 19, 2022
Merged
7 tasks
@srirambv srirambv mentioned this pull request Sep 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkdh darkdh darkdh approved these changes

Assignees

@cypt4 cypt4

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.45.x - Release
Development

Successfully merging this pull request may close these issues.

After wallet restoration the getSelectedAccount(CoinType.ETH) returns null (Brave-Core)
3 participants
@cypt4 @brave-builds @darkdh