-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes client hints UA to have invariable brand name. #15134
Conversation
Brand product name is used in the UA client hint string, but on MacOS our brand name varies based on the channel. This change assigns a fixed product name for when constructing the UA client hint string. Fixes brave/brave-browser#25459
2759758
to
91e31f3
Compare
Added a unit test. |
|
Example |
Example |
---|---|
![]() |
![]() |
AllowCertainClientHintsStudy:Disabled
(set as 50%
)
Verification PASSED on Samsung S10+
running Android 12
using the following build(s):
Brave | 1.46.32 Chromium: 106.0.5249.91 (Official Build) canary (32-bit)
--- | ---
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS | Android 12; Build/SP1A.210812.016
Launched 1.46.32 Chromium: 106.0.5249.91
using the instructions outlined via #10408 (comment) and ensured the following:
- ensured that
sec-ch-ua
,sec-ch-ua-mobile
&sec-ch-platform
weren't present via theRequest Headers
Example |
Example |
---|---|
![]() |
![]() |
Fixes brave/brave-browser#25459
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: