Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes client hints UA to have invariable brand name. (uplift to 1.44.x) #15155

Closed
wants to merge 1 commit into from
Closed

Fixes client hints UA to have invariable brand name. (uplift to 1.44.x) #15155

wants to merge 1 commit into from

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Sep 21, 2022 •
edited by mkarolin
Loading

brave/brave-browser#25459
Uplift of #15134

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner September 21, 2022 13:46
@brave-builds brave-builds self-assigned this Sep 21, 2022
@brave-builds brave-builds added this to the 1.44.x - Release milestone Sep 21, 2022
@kjozwiak
Copy link
Member

Closing as per discussion with @mkarolin. We'll get this uplifted into 1.45.x via #15154 and let it ride the trains.

@kjozwiak kjozwiak closed this Sep 22, 2022
@kjozwiak kjozwiak deleted the pr15134_maxk-fix-sec-ch-ua_1.44.x branch September 22, 2022 00:46
@kjozwiak kjozwiak removed the request for review from a team September 22, 2022 00:47
@kjozwiak kjozwiak removed this from the 1.44.x - Release milestone Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases