Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SidebarItem instead of copying #15310

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Move SidebarItem instead of copying #15310

merged 1 commit into from
Oct 3, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Oct 1, 2022

issue: brave/brave-browser#25383

f/u PR for https://github.com/brave/brave-core/pull/15252/files#r983217073

As SidebarItem has only default ctor/dtor, we can move it now with implicitely added move ctor.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@simonhong simonhong requested a review from goodov October 1, 2022 03:38
@simonhong simonhong self-assigned this Oct 1, 2022
@simonhong simonhong enabled auto-merge October 3, 2022 08:56
@simonhong simonhong merged commit 96a89f5 into master Oct 3, 2022
@simonhong simonhong deleted the fu_pr15252 branch October 3, 2022 10:46
@github-actions github-actions bot added this to the 1.46.x - Nightly milestone Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants