Fixes leaking of full version via navigator.userAgentData.getHighEntropyValues #16177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#23491
It seems
uaFullVersion
was always leaking but thefullVersionList
started leaking because of the change in#14155 where brand was added to
GetUserAgentBrandList
function incomponents/embedder_support/user_agent_utils.cc
which broke theBraveContentBrowserClient::GetUserAgentMetadata
expectation that the brand list would only contain 2 items (instead of now 3).This fix adjusts the
BraveContentBrowserClient::GetUserAgentMetadata
expectations and removes adding the Brave brand to the lists because it's already there. Now we just zero out the 3 last components of the full versions list anduaFullVersion
string.Also, adds a browser test to check the sizes of the lists and versions values.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: