-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds back certain UA client hints. #24763
Adds back certain UA client hints. #24763
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix works great! Will defer the implementation details to @ShivanKaul 😄
- `Sec-CH-UA-Arch`: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Sec-CH-UA-Arch - `Sec-CH-UA-Bitness`: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Sec-CH-UA-Bitness - `Sec-CH-UA-Full-Version-List`: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Sec-CH-UA-Full-Version-List - `Sec-CH-UA-WoW64`: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Sec-CH-UA-WoW64
76e6634
to
017771a
Compare
Just a note that we will be clamping to the major version for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Verification PASSED on
Using reproducedIssue.mp4Using the same STR/Cases as per the above, verified that the fixedIssueChat.mp4
|
Uplift of #24763 (squashed) to beta
Sec-CH-UA-Arch
: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Sec-CH-UA-ArchSec-CH-UA-Bitness
: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Sec-CH-UA-BitnessSec-CH-UA-Full-Version-List
: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Sec-CH-UA-Full-Version-ListSec-CH-UA-WoW64
: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Sec-CH-UA-WoW64Resolves brave/brave-browser#25694
Security review: https://github.com/brave/reviews/issues/1696
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Load YouTube live streams that have the chat enabled (e.g. https://www.youtube.com/watch?v=_uMuuHk_KkQ) multiple times, and make sure the
https://www.youtube.com/live_chat?continuation=...
requests never hang (i.e. live chat loads right away/together with the video/page — and not with a 20-sec delay). The 20-sec delay can easily be reprod on any channel/any version at the moment.