-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wallet): Show correct balance and asset #17540
Conversation
- Fix invalid balance state - Keep the selected to asset after account switching - Clean up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Code looks good.
android:layout_width="wrap_content" | ||
android:layout_height="wrap_content" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
layout_width
and layout_height
can be removed as they are inherited by BraveWalletButton
style .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, though just a small unharmful single nit, too small for another push and CI build, will address in another PR.
Verification passed on Oppo Reno 5 with Android 13 running 1.51.29 x64 Nightly build
17540.mp4 |
Uplift of #17540 (squashed) to beta
Uplift of #17540 (squashed) to release
Resolves brave/brave-browser#28879
Resolves brave/brave-browser#28914
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
asset-balance.webm
Additional:
Swap "To" asset is not persisted after account switch. will log an issue after discussion.