Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet): Show correct balance and asset (uplift to 1.50.x) #17554

Merged
merged 1 commit into from
Mar 14, 2023
Merged

fix(wallet): Show correct balance and asset (uplift to 1.50.x) #17554

merged 1 commit into from
Mar 14, 2023

Conversation

Pavneet-Sing
Copy link

@Pavneet-Sing Pavneet-Sing commented Mar 10, 2023 •
edited by kjozwiak
Loading

Uplift of #17540
Resolves brave/brave-browser#28879
Resolves brave/brave-browser#28914

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@Pavneet-Sing Pavneet-Sing requested a review from a team as a code owner March 10, 2023 05:58
@Pavneet-Sing Pavneet-Sing self-assigned this Mar 10, 2023
@Pavneet-Sing Pavneet-Sing added this to the 1.50.x - Beta milestone Mar 10, 2023
@Pavneet-Sing Pavneet-Sing added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Mar 10, 2023
kjozwiak
kjozwiak approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.50.x approved 👍 QA has verified the PR on Nightly as per #17540 (comment).

@kjozwiak kjozwiak merged commit 405af88 into 1.50.x Mar 14, 2023
@kjozwiak kjozwiak deleted the pr17540_fix-invalid-balance-and-asset_1.50.x branch March 14, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@Pavneet-Sing Pavneet-Sing

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.50.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@Pavneet-Sing @kjozwiak