-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable site affiliation fetcher #18153
Conversation
can we add a network audit test for this? if calling some PasswordManager API directly from the code will trigger this, then it would be enough. |
Looks like it works indeed. I instrumented the fetching code (where the macro is) and confirmed that without my fix, adding an entry to the password manager in the browser test does trigger the fetch. So I've added it to the beginning of the network auditor. |
cbd2941
to
a27c92d
Compare
patches/components-password_manager-core-browser-affiliation-hash_affiliation_fetcher.cc.patch
Outdated
Show resolved
Hide resolved
patches/components-password_manager-core-browser-affiliation-hash_affiliation_fetcher.cc.patch
Outdated
Show resolved
Hide resolved
a27c92d
to
c767130
Compare
c767130
to
5544b40
Compare
...src/components/password_manager/core/browser/affiliation/affiliation_fetcher_factory_impl.cc
Outdated
Show resolved
Hide resolved
5544b40
to
0c01bd6
Compare
Verification PASSED on
Reproduced the original issue using Using the same STR/Cases outlined above, verified that the
|
Uplift of #18153 (squashed) to beta
Uplift of #18153 (squashed) to release
commit c98ff5e Author: brave-builds <brave-builds+devops@brave.com> Date: Fri Apr 28 08:29:10 2023 +0000 1.51.107 commit ce813ef Author: Max <41635752+mkarolin@users.noreply.github.com> Date: Fri Apr 28 04:25:41 2023 -0400 Upgrade from Chromium 113.0.5672.53 to Chromium 113.0.5672.63 (1.51.x). (#18269) * Upgrade from Chromium 113.0.5672.53 to Chromium 113.0.5672.63 * Upgrade patches from Chromium 113.0.5672.53 to Chromium 113.0.5672.63 * Update pins list timestamp * Temporarily disables WindowClosingConfirmBrowserTest.TestWithDownload on MacOS. The test fails because in Chromium Private/Incognito profiles now ignore the "Ask for download location" setting and always prompt for the location. We will fix that in brave/brave-browser#29823, but until then let's disable this test on MacOS. --------- Co-authored-by: brave-builds <brave-builds+devops@brave.com> commit b18aeae Author: brave-builds <45370463+brave-builds@users.noreply.github.com> Date: Fri Apr 28 10:15:10 2023 +0200 Disable site affiliation fetcher (uplift to 1.51.x) (#18286) Uplift of #18153 (squashed) to release commit 6b1db58 Author: brave-builds <45370463+brave-builds@users.noreply.github.com> Date: Fri Apr 28 09:47:20 2023 +0200 Revise the behavior of "Extensions (Brave Wallet fallback)" setting (uplift to 1.51.x) (#18228) Uplift of #18172 (squashed) to beta commit f7f8042 Author: brave-builds <45370463+brave-builds@users.noreply.github.com> Date: Fri Apr 28 09:42:41 2023 +0200 Send kUAModel and kUAPlatformVersion CHs when requested. (uplift to 1.51.x) (#18263) Uplift of #18154 (squashed) to beta commit 545fa57 Author: Max <41635752+mkarolin@users.noreply.github.com> Date: Fri Apr 28 03:07:51 2023 -0400 Don't call GetSessionRoute() when media router is disabled (#18245) (1.51.x). (#18264) Don't call GetSessionRoute() when media router is disabled (#18245) Otherwise, it would end in reaching NOTREACHED() Co-authored-by: Sangwoo Ko <sko@brave.com> commit 0fbe592 Author: Arthur Edelstein <aedelstein@brave.com> Date: Thu Apr 27 17:44:23 2023 -0700 Uplift HTTPS First Mode v2 Migration (#17856) and HTTP error code fallback (#18141) (#18179) * Migrate to HttpsFirstMode v2 (#17856) Migrate HTTPS by Default feature to use HttpsFirstMode v2 * Force HTTPS Upgrader to fall back to HTTP if we have an HTTP error code (#18141) commit e369d71 Author: Aleksey Khoroshilov <5928869+goodov@users.noreply.github.com> Date: Fri Apr 28 03:34:51 2023 +0700 Disable flaky upstream tests. (Uplift to 1.51.x) (#18274) Update nft-details.tsx
Hide network icon commit c98ff5e Author: brave-builds <brave-builds+devops@brave.com> Date: Fri Apr 28 08:29:10 2023 +0000 1.51.107 commit ce813ef Author: Max <41635752+mkarolin@users.noreply.github.com> Date: Fri Apr 28 04:25:41 2023 -0400 Upgrade from Chromium 113.0.5672.53 to Chromium 113.0.5672.63 (1.51.x). (#18269) * Upgrade from Chromium 113.0.5672.53 to Chromium 113.0.5672.63 * Upgrade patches from Chromium 113.0.5672.53 to Chromium 113.0.5672.63 * Update pins list timestamp * Temporarily disables WindowClosingConfirmBrowserTest.TestWithDownload on MacOS. The test fails because in Chromium Private/Incognito profiles now ignore the "Ask for download location" setting and always prompt for the location. We will fix that in brave/brave-browser#29823, but until then let's disable this test on MacOS. --------- Co-authored-by: brave-builds <brave-builds+devops@brave.com> commit b18aeae Author: brave-builds <45370463+brave-builds@users.noreply.github.com> Date: Fri Apr 28 10:15:10 2023 +0200 Disable site affiliation fetcher (uplift to 1.51.x) (#18286) Uplift of #18153 (squashed) to release commit 6b1db58 Author: brave-builds <45370463+brave-builds@users.noreply.github.com> Date: Fri Apr 28 09:47:20 2023 +0200 Revise the behavior of "Extensions (Brave Wallet fallback)" setting (uplift to 1.51.x) (#18228) Uplift of #18172 (squashed) to beta commit f7f8042 Author: brave-builds <45370463+brave-builds@users.noreply.github.com> Date: Fri Apr 28 09:42:41 2023 +0200 Send kUAModel and kUAPlatformVersion CHs when requested. (uplift to 1.51.x) (#18263) Uplift of #18154 (squashed) to beta commit 545fa57 Author: Max <41635752+mkarolin@users.noreply.github.com> Date: Fri Apr 28 03:07:51 2023 -0400 Don't call GetSessionRoute() when media router is disabled (#18245) (1.51.x). (#18264) Don't call GetSessionRoute() when media router is disabled (#18245) Otherwise, it would end in reaching NOTREACHED() Co-authored-by: Sangwoo Ko <sko@brave.com> commit 0fbe592 Author: Arthur Edelstein <aedelstein@brave.com> Date: Thu Apr 27 17:44:23 2023 -0700 Uplift HTTPS First Mode v2 Migration (#17856) and HTTP error code fallback (#18141) (#18179) * Migrate to HttpsFirstMode v2 (#17856) Migrate HTTPS by Default feature to use HttpsFirstMode v2 * Force HTTPS Upgrader to fall back to HTTP if we have an HTTP error code (#18141) commit e369d71 Author: Aleksey Khoroshilov <5928869+goodov@users.noreply.github.com> Date: Fri Apr 28 03:34:51 2023 +0700 Disable flaky upstream tests. (Uplift to 1.51.x) (#18274) Update nft-details.tsx
Resolves brave/brave-browser#29872
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
See steps in brave/brave-browser#29872 (comment)