Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send kUAModel and kUAPlatformVersion CHs when requested. #18154

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

mkarolin
Copy link
Collaborator

Resolves brave/brave-browser#29875

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin self-assigned this Apr 20, 2023
@mkarolin mkarolin force-pushed the maxk-fix-critical-ch branch 8 times, most recently from 664ce5f to d4b86c2 Compare April 22, 2023 04:44
@mkarolin mkarolin requested review from pes10k, fmarier and goodov April 22, 2023 14:21
@mkarolin mkarolin force-pushed the maxk-fix-critical-ch branch from d4b86c2 to db785f6 Compare April 22, 2023 14:31
Copy link
Contributor

@pes10k pes10k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks terrific! Did not realize such a (seemingly) small change would need so much code. Thank you for sorting this out!

Just to verify, the initial build value for the clamped version will be “0”, but we could change it to something else (like “x”) using griffin?

@mkarolin mkarolin marked this pull request as ready for review April 23, 2023 18:09
@mkarolin mkarolin requested a review from a team as a code owner April 23, 2023 18:09
@mkarolin
Copy link
Collaborator Author

Thanks @pes10k, a lot of the changes are for tests. Yes, the default value is set to "0", but the parameter type is a string, so it can take "x" (I used "x" in one of the tests).

@mkarolin mkarolin force-pushed the maxk-fix-critical-ch branch from c8b11a8 to f946678 Compare April 26, 2023 14:53
@mkarolin
Copy link
Collaborator Author

Rebased and squashed.

@mkarolin mkarolin merged commit cfeed13 into master Apr 26, 2023
@mkarolin mkarolin deleted the maxk-fix-critical-ch branch April 26, 2023 22:56
@mkarolin mkarolin added this to the 1.52.x - Nightly milestone Apr 26, 2023
@github-actions github-actions bot added the CI/run-network-audit Run network-audit label Apr 26, 2023
brave-builds added a commit that referenced this pull request Apr 26, 2023
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.53.4 Chromium: 113.0.5672.53 (Official Build) nightly (64-bit)
-- | --
Revision | 12f5dac35d12e8f4e72d7dd11df557ef93bc046f-refs/branch-heads/5672@{#703}
OS | Windows 11 Version 22H2 (Build 22621.1555)

Using the STR/Cases outlined via brave/brave-browser#29875 (comment), reproduced the using 1.52.77 Chromium: 113.0.5672.53. However, I could only reproduce the issue with this link . Seems like this link loaded fine.

1.52.77 Chromium: 113.0.5672.53 1.52.77 Chromium: 113.0.5672.53
reproduced0 reproduced1

Using the STR/Cases mentioned above, verified that both websites are correctly loading as per the following:

Example Example Example
fixed1 fixed2 fixed3

kjozwiak pushed a commit that referenced this pull request Apr 28, 2023
muliswilliam added a commit that referenced this pull request Apr 28, 2023
commit c98ff5e
Author: brave-builds <brave-builds+devops@brave.com>
Date:   Fri Apr 28 08:29:10 2023 +0000

    1.51.107

commit ce813ef
Author: Max <41635752+mkarolin@users.noreply.github.com>
Date:   Fri Apr 28 04:25:41 2023 -0400

    Upgrade from Chromium 113.0.5672.53 to Chromium 113.0.5672.63 (1.51.x). (#18269)

    * Upgrade from Chromium 113.0.5672.53 to Chromium 113.0.5672.63

    * Upgrade patches from Chromium 113.0.5672.53 to Chromium 113.0.5672.63

    * Update pins list timestamp

    * Temporarily disables WindowClosingConfirmBrowserTest.TestWithDownload on MacOS.

    The test fails because in Chromium Private/Incognito profiles now ignore the
    "Ask for download location" setting and always prompt for the location.
    We will fix that in brave/brave-browser#29823,
    but until then let's disable this test on MacOS.

    ---------

    Co-authored-by: brave-builds <brave-builds+devops@brave.com>

commit b18aeae
Author: brave-builds <45370463+brave-builds@users.noreply.github.com>
Date:   Fri Apr 28 10:15:10 2023 +0200

    Disable site affiliation fetcher (uplift to 1.51.x) (#18286)

    Uplift of #18153 (squashed) to release

commit 6b1db58
Author: brave-builds <45370463+brave-builds@users.noreply.github.com>
Date:   Fri Apr 28 09:47:20 2023 +0200

    Revise the behavior of "Extensions (Brave Wallet fallback)" setting (uplift to 1.51.x) (#18228)

    Uplift of #18172 (squashed) to beta

commit f7f8042
Author: brave-builds <45370463+brave-builds@users.noreply.github.com>
Date:   Fri Apr 28 09:42:41 2023 +0200

    Send kUAModel and kUAPlatformVersion CHs when requested. (uplift to 1.51.x) (#18263)

    Uplift of #18154 (squashed) to beta

commit 545fa57
Author: Max <41635752+mkarolin@users.noreply.github.com>
Date:   Fri Apr 28 03:07:51 2023 -0400

    Don't call GetSessionRoute() when media router is disabled (#18245) (1.51.x). (#18264)

    Don't call GetSessionRoute() when media router is disabled (#18245)

    Otherwise, it would end in reaching NOTREACHED()

    Co-authored-by: Sangwoo Ko <sko@brave.com>

commit 0fbe592
Author: Arthur Edelstein <aedelstein@brave.com>
Date:   Thu Apr 27 17:44:23 2023 -0700

    Uplift HTTPS First Mode v2 Migration (#17856) and HTTP error code fallback (#18141) (#18179)

    * Migrate to HttpsFirstMode v2 (#17856)

    Migrate HTTPS by Default feature to use HttpsFirstMode v2

    * Force HTTPS Upgrader to fall back to HTTP if we have an HTTP error code (#18141)

commit e369d71
Author: Aleksey Khoroshilov <5928869+goodov@users.noreply.github.com>
Date:   Fri Apr 28 03:34:51 2023 +0700

    Disable flaky upstream tests. (Uplift to 1.51.x) (#18274)

Update nft-details.tsx
kjozwiak pushed a commit that referenced this pull request May 1, 2023
Hide network icon

commit c98ff5e
Author: brave-builds <brave-builds+devops@brave.com>
Date:   Fri Apr 28 08:29:10 2023 +0000

    1.51.107

commit ce813ef
Author: Max <41635752+mkarolin@users.noreply.github.com>
Date:   Fri Apr 28 04:25:41 2023 -0400

    Upgrade from Chromium 113.0.5672.53 to Chromium 113.0.5672.63 (1.51.x). (#18269)

    * Upgrade from Chromium 113.0.5672.53 to Chromium 113.0.5672.63

    * Upgrade patches from Chromium 113.0.5672.53 to Chromium 113.0.5672.63

    * Update pins list timestamp

    * Temporarily disables WindowClosingConfirmBrowserTest.TestWithDownload on MacOS.

    The test fails because in Chromium Private/Incognito profiles now ignore the
    "Ask for download location" setting and always prompt for the location.
    We will fix that in brave/brave-browser#29823,
    but until then let's disable this test on MacOS.

    ---------

    Co-authored-by: brave-builds <brave-builds+devops@brave.com>

commit b18aeae
Author: brave-builds <45370463+brave-builds@users.noreply.github.com>
Date:   Fri Apr 28 10:15:10 2023 +0200

    Disable site affiliation fetcher (uplift to 1.51.x) (#18286)

    Uplift of #18153 (squashed) to release

commit 6b1db58
Author: brave-builds <45370463+brave-builds@users.noreply.github.com>
Date:   Fri Apr 28 09:47:20 2023 +0200

    Revise the behavior of "Extensions (Brave Wallet fallback)" setting (uplift to 1.51.x) (#18228)

    Uplift of #18172 (squashed) to beta

commit f7f8042
Author: brave-builds <45370463+brave-builds@users.noreply.github.com>
Date:   Fri Apr 28 09:42:41 2023 +0200

    Send kUAModel and kUAPlatformVersion CHs when requested. (uplift to 1.51.x) (#18263)

    Uplift of #18154 (squashed) to beta

commit 545fa57
Author: Max <41635752+mkarolin@users.noreply.github.com>
Date:   Fri Apr 28 03:07:51 2023 -0400

    Don't call GetSessionRoute() when media router is disabled (#18245) (1.51.x). (#18264)

    Don't call GetSessionRoute() when media router is disabled (#18245)

    Otherwise, it would end in reaching NOTREACHED()

    Co-authored-by: Sangwoo Ko <sko@brave.com>

commit 0fbe592
Author: Arthur Edelstein <aedelstein@brave.com>
Date:   Thu Apr 27 17:44:23 2023 -0700

    Uplift HTTPS First Mode v2 Migration (#17856) and HTTP error code fallback (#18141) (#18179)

    * Migrate to HttpsFirstMode v2 (#17856)

    Migrate HTTPS by Default feature to use HttpsFirstMode v2

    * Force HTTPS Upgrader to fall back to HTTP if we have an HTTP error code (#18141)

commit e369d71
Author: Aleksey Khoroshilov <5928869+goodov@users.noreply.github.com>
Date:   Fri Apr 28 03:34:51 2023 +0700

    Disable flaky upstream tests. (Uplift to 1.51.x) (#18274)

Update nft-details.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Absent critical client hints cause some sites to get into infinite loop redirects.
4 participants