Revert "[WIP] Remove passkey entitlement" #19040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emerick
added
CI/skip-android
mihaiplesa
added
CI/skip
mihaiplesa
force-pushed
the
cr115-followup-reinstate-passkey-entitlement
branch
from
2ddbdfb to
77b0793
Compare
goodov
approved these changes
Jun 27, 2023
|
Verified with PR build: Confirmed able to install and launch build from https://bravesoftware.slack.com/archives/CU5UXM3EC/p1687882211614169?thread_ts=1687009981.243379&cid=CU5UXM3EC. Confirmed entitlement (run below and confirm that the xml contains On a clean profile verified the following (adapted from https://github.com/brave/brave-browser/wiki/Chromium-rebases#smoke-test)
Other items checked on clean profile:
Simulated an "upgrade" to PR build:
|
Verification
|
| Brave | 1.55.14 Chromium: 115.0.5790.40 (Official Build) nightly (arm64) |
|---|---|
| Revision | 071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979} |
| OS | macOS Version 11.7.8 (Build 20G1351) |
Binary used: https://build-artifacts.brave.com/test-brave-browser-build-macos-arm64/375/Brave-Browser-Nightly-arm64.dmg
- confirmed able to launch build
- confirmed no errors on install/launch
- confirmed build is signed:
stephendonner@Stephens-MBP-3 ~ % spctl --assess --verbose /Applications/Brave\ Browser\ Nightly.app
/Applications/Brave Browser Nightly.app: accepted
source=Notarized Developer ID
Confirmed entitlement
stephendonner@Stephens-MBP-3 /Applications % codesign -d --entitlements - /Applications/Brave\ Browser\ Nightly.app
Executable=/Applications/Brave Browser Nightly.app/Contents/MacOS/Brave Browser Nightly
��qq9<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>com.apple.application-identifier</key>
<string>KL8N8XSYF4.com.brave.Browser.nightly</string>
<key>com.apple.developer.associated-domains.applinks.read-write</key>
<true/>
<key>com.apple.developer.networking.vpn.api</key>
<array>
<string>allow-vpn</string>
</array>
<key>com.apple.developer.web-browser.public-key-credential</key>
<true/>
<key>com.apple.security.device.audio-input</key>
<true/>
<key>com.apple.security.device.bluetooth</key>
<true/>
<key>com.apple.security.device.camera</key>
<true/>
<key>com.apple.security.device.print</key>
<true/>
<key>com.apple.security.device.usb</key>
<true/>
<key>com.apple.security.personal-information.location</key>
<true/>
<key>keychain-access-groups</key>
<array>
<string>KL8N8XSYF4.com.brave.Browser.nightly.devicetrust</string>
<string>KL8N8XSYF4.com.brave.Browser.nightly.webauthn</string>
</array>
</dict>
</plist>
stephendonner@Stephens-MBP-3 /Applications %
On a clean profile, I verified the following:
- brave://version loads
- each section under brave://settings loads and no errors are displayed in browser console
- tabs have the expected shape (it's slightly different from Chrome)
- clearing browser data on exit works as expected
- videos play properly on YouTube and that the media device toolbar button works correctly
- tab-muting works as expected (spot checked using audio icon on tab and the "Mute tab" and "Mute site" options from the right-click tab menu)
- spot check of vertical tabs (enabling/disabling
- able to join Rewards on fresh profile
- able to enable sidebar and select each of the options (Talk, Wallet, Bookmarks, Reading List)
- able to create a second profile
- private and Tor windows worked as expected
- websites loaded as expected
- able to open/load DevTools
Other items checked on a clean profile:
- cookies are retained on app relaunch
brave://componentsdoes not show any errors- can create bookmarks
Simulated an "upgrade" to PR build:
- Installed 1.52.126 (
NightlyChannel) - Populated a profile with tabs, windows, browsing data, rewards data, cookies, etc.
- "upgraded" to PR build (
1.55.14onNightlychannel) - Confirmed no errors on launch or while browsing
- Confirmed expected data was retained after upgrade: tabs, windows, browsing data, Rewards data, cookies, stats, saved login info, Shield settings, etc.
|
Verified with PR build: Confirmed able to install and launch build from https://bravesoftware.slack.com/archives/CU5UXM3EC/p1687969613674689?thread_ts=1687009981.243379&cid=CU5UXM3EC. Confirmed entitlement (run below and confirm that the xml contains On a clean profile verified the following (adapted from https://github.com/brave/brave-browser/wiki/Chromium-rebases#smoke-test)
Other items checked on clean profile:
Simulated an "upgrade" to PR build:
|
Verification
|
This reverts commit dc06648.
emerick
force-pushed
the
cr115-followup-reinstate-passkey-entitlement
branch
from
77b0793 to
0f2a938
Compare
brave-builds
added a commit
that referenced
this pull request
Jun 29, 2023
7 tasks
brave-builds
added a commit
that referenced
this pull request
Jun 29, 2023
7 tasks
|
Verified with CI build Confirmed able to install and launch above build. Confirmed entitlement (run below and confirm that the xml contains On a clean profile verified the following (adapted from https://github.com/brave/brave-browser/wiki/Chromium-rebases#smoke-test)
Other items checked on clean profile:
Simulated an "upgrade" to Nightly build:
|
|
Verified with CI build Confirmed able to install and launch above build. Confirmed entitlement (run below and confirm that the xml contains On a clean profile verified the following (adapted from https://github.com/brave/brave-browser/wiki/Chromium-rebases#smoke-test)
Other items checked on clean profile:
Simulated an "upgrade" to Nightly build:
|
Verification
|
Verified
|
| Brave | 1.55.85 Chromium: 115.0.5790.56 (Official Build) nightly (arm64) |
|---|---|
| Revision | ec8df43 |
| OS | macOS Version 11.7.8 (Build 20G1351) |
- confirmed able to launch build
- confirmed no errors on install/launch
- confirmed build is signed:
stephendonner@Stephens-MBP-3 /Applications % spctl --assess --verbose /Applications/Brave\ Browser\ Nightly.app
/Applications/Brave Browser Nightly.app: accepted
source=Notarized Developer ID
stephendonner@Stephens-MBP-3 /Applications %```
Confirmed entitlement:
stephendonner@Stephens-MBP-3 /Applications % codesign -d --entitlements - /Applications/Brave\ Browser\ Nightly.app
Executable=/Applications/Brave Browser Nightly.app/Contents/MacOS/Brave Browser Nightly
��qq9<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>com.apple.application-identifier</key>
<string>KL8N8XSYF4.com.brave.Browser.nightly</string>
<key>com.apple.developer.associated-domains.applinks.read-write</key>
<true/>
<key>com.apple.developer.networking.vpn.api</key>
<array>
<string>allow-vpn</string>
</array>
<key>com.apple.developer.web-browser.public-key-credential</key>
<true/>
<key>com.apple.security.device.audio-input</key>
<true/>
<key>com.apple.security.device.bluetooth</key>
<true/>
<key>com.apple.security.device.camera</key>
<true/>
<key>com.apple.security.device.print</key>
<true/>
<key>com.apple.security.device.usb</key>
<true/>
<key>com.apple.security.personal-information.location</key>
<true/>
<key>keychain-access-groups</key>
<array>
<string>KL8N8XSYF4.com.brave.Browser.nightly.devicetrust</string>
<string>KL8N8XSYF4.com.brave.Browser.nightly.webauthn</string>
</array>
</dict>
</plist>
stephendonner@Stephens-MBP-3 /Applications %
On a clean profile, I verified the following:
brave://versionloads- each section under brave://settings loads and no errors are displayed in browser console
- tabs have the expected shape (it's slightly different from Chrome)
- clearing browser data on exit works as expected
- videos play properly on YouTube and that the media device toolbar button works correctly
- tab-muting works as expected (spot checked using audio icon on tab and the "Mute tab" and "Mute site" options from the right-click tab menu)
- spot check of vertical tabs (enabling/disabling
- able to join Rewards on fresh profile
- able to enable sidebar and select each of the options (Talk, Wallet, Bookmarks, Reading List)
- able to create a second profile
- private and Tor windows worked as expected
- websites loaded as expected
- able to open/load DevTools
Other items checked on a clean profile:
- cookies are retained on app relaunch
brave://componentsdoes not show any errors- can create bookmarks
Simulated an "upgrade" to PR build:
- Installed
1.52.129(ReleaseChannel) - Populated a profile with tabs, windows, browsing data, rewards data, cookies, etc.
- "upgraded" to PR build (
1.55.85onNightlychannel) - Confirmed no errors on launch or while browsing
- Confirmed expected data was retained after upgrade: tabs, windows, browsing data, Rewards data, cookies, stats, saved login info, Shield settings, etc.
kjozwiak
pushed a commit
that referenced
this pull request
Jul 2, 2023
Uplift of #19040 (squashed) to beta
kjozwiak
pushed a commit
that referenced
this pull request
Jul 2, 2023
Uplift of #19040 (squashed) to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#31258
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: