Upgrading brave-ui -> 0.34.6 #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanml
changed the title
petemill
previously approved these changes
Nov 29, 2018
ryanml
commented
Nov 29, 2018
| @@ -304,7 +304,7 @@ export class Panel extends React.Component<Props, State> { | |||
| platform={publisher.provider as Provider} | |||
| publisherName={publisher.name} | |||
| publisherImg={faviconUrl} | |||
| monthlyAmount={10} | |||
| monthlyAmount={'10.0'} | |||
There was a problem hiding this comment.
This is changed here to a string float to accommodate an update in brave-ui to monthlyAmount type.
Currently nothing is done with monthlyAmount but will work as of: #957
bsclifton
approved these changes
Nov 29, 2018
bsclifton
added a commit
that referenced
this pull request
Nov 29, 2018
Upgrading brave-ui -> 0.34.6
This was referenced May 4, 2020
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
Fixes: brave/brave-browser#2277
Contains the following updates:
Fixes console error concerning use of
fill-ruleFixes missing data-test-id from welcome page opt-in button
It should be verified that browser tests are passing with this PR
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
rm -rf node_modules && npm iYes, I'm in!buttondata-test-id='optInAction'Automated test plan
npm run test brave_browser_testsReviewer Checklist: