Adds functionality to monthly contribution dropdown (Panel) #957

ryanml · 2018-11-27T02:46:04Z

The brunt of the work for this was adding extension functions to support:

Adding a recurring contribution
Removing a recurring contribution
Retrieving recurring contributions

Submitter Checklist:

Test Plan:

Enable Brave Rewards
Navigate to a site such as brave.com
Bring up the wallet panel.
Change monthly contribution amount to '5.0'
Close and re-open panel
Confirm that the value '5.0' persists
Confirm that the change is reflected in the donation table

The above six steps should be tried in different ways with different values. Ex: Ensuring that the data persists across tabs with the same site open

Reviewer Checklist:

New files have MPL-2.0 license header.
Request a security/privacy review as needed.
Adequate test coverage exists to prevent regressions
Verify test plan is specified in PR before merging to source

components/brave_rewards/browser/BUILD.gn

components/brave_rewards/browser/extension_rewards_service_observer.h

NejcZdovc · 2018-11-27T04:26:30Z

components/brave_rewards/browser/rewards_service_impl.cc

@@ -1502,6 +1508,10 @@ void RewardsServiceImpl::OnTipsUpdatedData(const ledger::PublisherInfoList list)
  }
 }

+void RewardsServiceImpl::AddRecurringPayment(const std::string& publisher_key, double new_amount) {


Can we just use SaveRecurringDonation directly? So that we don't need to add new function

@NejcZdovc SaveRecurringDonation is marked private and wouldn't be accessible to brave_rewards_api and tests

...brave_rewards/resources/extension/brave_rewards/background/reducers/rewards_panel_reducer.ts

ryanml · 2018-11-28T02:05:27Z

components/brave_rewards/browser/extension_rewards_service_observer.cc

+          .release());
+
+  std::unique_ptr<extensions::Event> event(new extensions::Event(
+      extensions::events::BRAVE_START,


Using BRAVE_START constant per @bridiver

ryanml · 2018-11-28T02:06:23Z

components/brave_rewards/resources/extension/brave_rewards/components/panel.tsx

+                onAmountChange={this.onContributionAmountChange.bind(this, publisher.publisher_key)}
+                onIncludeInAuto={this.switchAutoContribute}
+              />
+              <div style={{ height: '48px' }}></div>


This is a place holder that fills the space that would be taken up by the "Enable tips on action" component. This will be reworked once that feature is supported.

ryanml · 2018-11-28T02:07:15Z

test/BUILD.gn

@@ -306,6 +307,7 @@ test("brave_browser_tests") {
    ":brave_browser_tests_deps",
    ":browser_tests_runner",
    "//testing/gmock",
+    "//brave/vendor/bat-native-ledger",


Adding because it was a dependency on unit tests only, not browser tests.

components/brave_rewards/browser/rewards_service_observer.h

bridiver

see comments

Using ContentSiteList now

jasonrsadler · 2018-11-30T02:04:07Z

@ryanml please rebase

ryanml · 2018-11-30T02:19:44Z

@jasonrsadler rebased

jasonrsadler · 2018-11-30T14:36:21Z

Currently getting build failure:

In file included from ../../brave/components/brave_rewards/browser/extension_rewards_service_observer.cc:5:
In file included from ../../brave/components/brave_rewards/browser/extension_rewards_service_observer.h:11:
../../brave/components/brave_rewards/browser/rewards_service_observer.h:56:7: error: use of undeclaredidentifier 'ledger'
      ledger::PublisherInfo* info,
      ^
In file included from ../../brave/components/brave_rewards/browser/extension_rewards_service_observer.cc:5:
../../brave/components/brave_rewards/browser/extension_rewards_service_observer.h:38:8: error: 'brave_rewards::ExtensionRewardsServiceObserver::OnGetPublisherActivityFromUrl' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
  void OnGetPublisherActivityFromUrl(
       ^
../../brave/components/brave_rewards/browser/rewards_service_observer.h:53:16: note: hidden overloadedvirtual function 'brave_rewards::RewardsServiceObserver::OnGetPublisherActivityFromUrl' declared here:type mismatch at 3rd parameter ('int *' vs 'std::unique_ptr<ledger::PublisherInfo>')
  virtual void OnGetPublisherActivityFromUrl(

emerick · 2018-11-30T14:40:40Z

@jasonrsadler I think you may need #985, which reverts a change that mistakenly added a ledger type to the Rewards public API.

jasonrsadler · 2018-11-30T14:50:21Z

Thanks @emerick
That seems to be the case as my master doesn't build either.
I'll resync and get back to this @ryanml

jasonrsadler · 2018-12-03T03:33:26Z

This might require another rebase to get building

ryanml · 2018-12-03T03:41:31Z

@jasonrsadler rebased

jasonrsadler

Amount picklist is clipped at borders.
Let me know if this is handled elsewhere:

ryanml · 2018-12-03T20:18:17Z

@jasonrsadler dropdown clipping is part of a larger issue, limited I believe by a chrome extension panel's capabilities. Cc: @petemill

petemill · 2018-12-03T20:51:18Z

@ryanml if we're going to use this custom html to simulate a dropdown, then we'll need to change it to avoid the viewport / window edge.

ryanml · 2018-12-03T20:55:40Z

@petemill my mistake, I remember that was the intended approach now, which is captured as part of this issue: brave/brave-ui#126

So this problem will be addressed separately, I need to work on the above issue soon.

clipping will be addessed separately

jasonrsadler · 2018-12-03T20:58:02Z

master (0.60.x): dcc6e31

bbondy · 2018-12-04T04:43:48Z

Reverted from master here due to failing unit tests:
f77acbe

ryanml added pr/work-in-progress feature/rewards labels Nov 27, 2018

ryanml self-assigned this Nov 27, 2018

This was referenced Nov 27, 2018

monthlyAmount prop in WalletPanel should be type string brave/brave-ui#291

Closed

Changing monthlyAmount prop to string brave/brave-ui#292

Merged

NejcZdovc reviewed Nov 27, 2018

View reviewed changes

components/brave_rewards/browser/BUILD.gn Outdated Show resolved Hide resolved

NejcZdovc reviewed Nov 27, 2018

View reviewed changes

components/brave_rewards/browser/extension_rewards_service_observer.h Outdated Show resolved Hide resolved

NejcZdovc reviewed Nov 27, 2018

View reviewed changes

...brave_rewards/resources/extension/brave_rewards/background/reducers/rewards_panel_reducer.ts Show resolved Hide resolved

NejcZdovc reviewed Nov 27, 2018

View reviewed changes

...brave_rewards/resources/extension/brave_rewards/background/reducers/rewards_panel_reducer.ts Show resolved Hide resolved

ryanml force-pushed the monthly-amount-dropdown branch 4 times, most recently from 89f5191 to 1873817 Compare November 28, 2018 02:01

ryanml requested review from bridiver, jasonrsadler and bbondy November 28, 2018 02:04

ryanml added PR/Pending Review and removed pr/work-in-progress labels Nov 28, 2018

ryanml commented Nov 28, 2018

View reviewed changes

ryanml requested a review from bsclifton November 28, 2018 08:16

ryanml mentioned this pull request Nov 28, 2018

Broken image in rewards panel brave/brave-browser#2259

Closed

bridiver reviewed Nov 28, 2018

View reviewed changes

components/brave_rewards/browser/rewards_service_observer.h Show resolved Hide resolved

bridiver previously requested changes Nov 28, 2018

View reviewed changes

ryanml requested a review from bridiver November 28, 2018 22:58

ryanml mentioned this pull request Nov 29, 2018

Upgrading brave-ui -> 0.34.6 #979

Merged

18 tasks

ryanml force-pushed the monthly-amount-dropdown branch from be4e3bc to 0ba41c0 Compare November 29, 2018 05:33

ryanml force-pushed the monthly-amount-dropdown branch from 0ba41c0 to fb19e25 Compare November 30, 2018 02:19

ryanml force-pushed the monthly-amount-dropdown branch from fb19e25 to 18f492a Compare December 3, 2018 03:41

Fixes brave/brave-browser#2245, monthly donation functionality

a4959e8

ryanml force-pushed the monthly-amount-dropdown branch from 18f492a to a4959e8 Compare December 3, 2018 05:34

jasonrsadler previously requested changes Dec 3, 2018

View reviewed changes

ryanml requested a review from jasonrsadler December 3, 2018 20:56

jasonrsadler approved these changes Dec 3, 2018

View reviewed changes

jasonrsadler merged commit dcc6e31 into brave:master Dec 3, 2018

jasonrsadler added the merged/0.60.x-Nightly label Dec 3, 2018

NejcZdovc removed the PR/Pending Review label Dec 4, 2018

bbondy mentioned this pull request Dec 4, 2018

Revert "Adds functionality to monthly contribution dropdown (Panel)" #1013

Merged

bbondy added merged/none and removed merged/0.60.x-Nightly labels Dec 4, 2018

srirambv mentioned this pull request Dec 12, 2018

Rewards panel has extra padding after rewards summary brave/brave-browser#2486

Closed

GeetaSarvadnya mentioned this pull request May 15, 2019

Monthly Contribution Dropdown in Wallet Panel should retain value brave/brave-browser#2245

Closed

NejcZdovc modified the milestones: Closed, 0.65.x - Release Mar 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds functionality to monthly contribution dropdown (Panel) #957

Adds functionality to monthly contribution dropdown (Panel) #957

ryanml commented Nov 27, 2018 •

edited

Loading

NejcZdovc Nov 27, 2018

jasonrsadler Nov 30, 2018 •

edited

Loading

ryanml Nov 28, 2018

ryanml Nov 28, 2018

ryanml Nov 28, 2018

bridiver left a comment

jasonrsadler commented Nov 30, 2018

ryanml commented Nov 30, 2018

jasonrsadler commented Nov 30, 2018

emerick commented Nov 30, 2018

jasonrsadler commented Nov 30, 2018

jasonrsadler commented Dec 3, 2018

ryanml commented Dec 3, 2018

jasonrsadler left a comment

ryanml commented Dec 3, 2018

petemill commented Dec 3, 2018

ryanml commented Dec 3, 2018

jasonrsadler commented Dec 3, 2018

bbondy commented Dec 4, 2018

Adds functionality to monthly contribution dropdown (Panel) #957

Adds functionality to monthly contribution dropdown (Panel) #957

Conversation

ryanml commented Nov 27, 2018 • edited Loading

Submitter Checklist:

Test Plan:

Reviewer Checklist:

NejcZdovc Nov 27, 2018

Choose a reason for hiding this comment

jasonrsadler Nov 30, 2018 • edited Loading

Choose a reason for hiding this comment

ryanml Nov 28, 2018

Choose a reason for hiding this comment

ryanml Nov 28, 2018

Choose a reason for hiding this comment

ryanml Nov 28, 2018

Choose a reason for hiding this comment

bridiver left a comment

Choose a reason for hiding this comment

jasonrsadler commented Nov 30, 2018

ryanml commented Nov 30, 2018

jasonrsadler commented Nov 30, 2018

emerick commented Nov 30, 2018

jasonrsadler commented Nov 30, 2018

jasonrsadler commented Dec 3, 2018

ryanml commented Dec 3, 2018

jasonrsadler left a comment

Choose a reason for hiding this comment

ryanml commented Dec 3, 2018

petemill commented Dec 3, 2018

ryanml commented Dec 3, 2018

jasonrsadler commented Dec 3, 2018

bbondy commented Dec 4, 2018

ryanml commented Nov 27, 2018 •

edited

Loading

jasonrsadler Nov 30, 2018 •

edited

Loading