Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

monthlyAmount prop in WalletPanel should be type string #291

Closed
ryanml opened this issue Nov 27, 2018 · 0 comments
Closed

monthlyAmount prop in WalletPanel should be type string #291

ryanml opened this issue Nov 27, 2018 · 0 comments
Assignees

Comments

@ryanml
Copy link
Contributor

ryanml commented Nov 27, 2018

Related: brave/brave-core#957

Should be string amount formatted like "5.0"

Current number typing is causing issues, passing in '5' (number) will not match any of the float token values. This is broken at this time and does not work even in storybook.

Per design we will soon need to have a string option in the wallet panel dropdown, such as 'Off'

This is in line with the typing for value on <Select />

@ryanml ryanml self-assigned this Nov 27, 2018
ryanml added a commit to ryanml/brave-ui that referenced this issue Nov 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant