only use brave:// url for display purposes because chrome does some s… #2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bridiver Can you add test plan? |
bbondy
previously approved these changes
Mar 21, 2019
| EXPECT_STREQ(url.c_str(), | ||
| base::UTF16ToUTF8(browser()->location_bar_model() | ||
| ->GetFormattedFullURL()).c_str()); | ||
| // EXPECT_EQ(url, active_contents()->GetVisibleURL()); |
| GURL::Replacements replacements; | ||
| replacements.SetSchemeStr(kBraveUIScheme); | ||
| *url = url->ReplaceComponents(replacements); | ||
| if (HandleURLOverrideRewrite(url, browser_context)) |
There was a problem hiding this comment.
nit
brace surround the if.
There was a problem hiding this comment.
You mean {}? That's only a JS lint issue, we generally don't use braces for one line in c++
There was a problem hiding this comment.
Yes. I usually include them anyway for readability. Wouldn't hold up an approval over it 🙂
…ecurity checks based on the virtual url fix brave/brave-browser#3411
fmarier
approved these changes
Mar 22, 2019
18 tasks
bridiver
added a commit
that referenced
this pull request
Mar 22, 2019
only use brave:// url for display purposes because chrome does some s…
19 tasks
bridiver
added a commit
that referenced
this pull request
Mar 22, 2019
only use brave:// url for display purposes because chrome does some s…
19 tasks
bbondy
added a commit
that referenced
this pull request
Mar 25, 2019
Merge pull request #2024 from /issues/3411
bbondy
added a commit
that referenced
this pull request
Mar 25, 2019
Merge pull request #2024 from /issues/3411
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ecurity checks based on the virtual url
fix brave/brave-browser#3411
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
chrome://versionin the urlbar - should load version page and urlbar should displaybrave://versionbrave://settingsin the urlbar - should load settings pagesyncin the settings page and click on the link forbrave://sync- should load sync pageReviewer Checklist: