Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #2024 from brave/issues/3411 #2032

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Conversation

bridiver
Copy link
Collaborator

Original PR #2024

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

only use brave:// url for display purposes because chrome does some s…
@bbondy
Copy link
Member

bbondy commented Mar 22, 2019

++ but please let it sit a day or two before merging so we can see it on Nightly first.

@jasonrsadler jasonrsadler removed their request for review March 25, 2019 14:36
@bbondy bbondy merged commit 2d7b229 into 0.62.x Mar 25, 2019
@bsclifton bsclifton added this to the 0.62.x - Beta milestone Mar 25, 2019
@mihaiplesa mihaiplesa deleted the issues/3411-0.62.x branch May 13, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants