Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Griffin seed on first launch on Android. #20244

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

goodov
Copy link
Member

@goodov goodov commented Sep 21, 2023

Re-enable VariationsSeedFetcher and point to Brave URL.

The fetch takes 1 second on my connection:

cr_VariationsSeedFetch: Fetched first run seed in 1004 ms

There are two timeouts in upstream code, so I assume the longest the fetch can delay the first startup is 4 seconds.

Resolves brave/brave-browser#33141

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov changed the title Download Griffin seed on first launch. Download Griffin seed on first launch on Android. Sep 21, 2023
@goodov goodov marked this pull request as ready for review September 22, 2023 07:55
@goodov goodov requested a review from a team as a code owner September 22, 2023 07:55
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@goodov goodov merged commit bcaeae3 into master Sep 22, 2023
9 checks passed
@goodov goodov deleted the issues/33141 branch September 22, 2023 12:57
@github-actions github-actions bot added this to the 1.60.x - Nightly milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable VariationsSeedFetcher to fetch Griffin seed on first run on Android
2 participants