Disable PrettyPrintJSONDocument #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
force-pushed
the
disable_pretty_print_json_document
branch
from
2f2e7d5
to
f0b8fee
Compare
tmancey
force-pushed
the
disable_pretty_print_json_document
branch
4 times, most recently
from
e2cd9c8
to
f59236f
Compare
tmancey
force-pushed
the
disable_pretty_print_json_document
branch
from
f59236f
to
297ef79
Compare
aseren
approved these changes
Sep 29, 2023
|
Example |
Example |
Example |
|---|---|---|
 |
 |
 |
- restarted
Braveusingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed - ensured that
PrettyPrintJSONDocument:Disabled_EmergencyKillSwitchviabrave://version - using the STR/Cases outlined via https://bugs.chromium.org/p/chromium/issues/detail?id=1485880, ensured that https://club.jd.com/comment/skuProductPageComments.action?productId=100066896420&score=0&sortType=6&page=0&pageSize=10&isShadowSku=0&fold=1 was loading without issues
Example |
Example |
|---|---|
 |
 |
BETA - PrettyPrintJSONDocument:Disabled_EmergencyKillSwitch
Verification PASSED on Win 11 x64 using the following build(s):
Brave | 1.59.107 Chromium: 117.0.5938.140 (Official Build) beta (64-bit)
-- | --
Revision | 5bbd53ed3e41461e15555b7ce0490464656b236f
OS | Windows 11 Version 22H2 (Build 22621.2361)
- downloaded/installed
1.59.107 Chromium: 117.0.5938.140and startedBraveusing the followingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
PrettyPrintJSONDocumentisn't visible underbrave://version
Example |
Example |
Example |
|---|---|---|
 |
 |
 |
- restarted
Braveusingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed - ensured that
PrettyPrintJSONDocument:Disabled_EmergencyKillSwitchviabrave://version - using the STR/Cases outlined via https://bugs.chromium.org/p/chromium/issues/detail?id=1485880, ensured that https://club.jd.com/comment/skuProductPageComments.action?productId=100066896420&score=0&sortType=6&page=0&pageSize=10&isShadowSku=0&fold=1 was loading without issues
Example |
Example |
|---|---|
 |
 |
Release - PrettyPrintJSONDocument:Disabled_EmergencyKillSwitch
Verification PASSED on Win 11 x64 using the following build(s):
Brave | 1.58.135 Chromium: 117.0.5938.140 (Official Build) (64-bit)
-- | --
Revision | 325e8592cad8c6badb656cab238b722ae46bf7bc
OS | Windows 11 Version 22H2 (Build 22621.2361)
- downloaded/installed
1.58.135 Chromium: 117.0.5938.140and startedBraveusing the followingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
PrettyPrintJSONDocumentisn't visible underbrave://version
Example |
Example |
Example |
|---|---|---|
 |
 |
 |
- restarted
Braveusingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed - ensured that
PrettyPrintJSONDocument:Disabled_EmergencyKillSwitchviabrave://version - using the STR/Cases outlined via https://bugs.chromium.org/p/chromium/issues/detail?id=1485880, ensured that https://club.jd.com/comment/skuProductPageComments.action?productId=100066896420&score=0&sortType=6&page=0&pageSize=10&isShadowSku=0&fold=1 was loading without issues
Example |
Example |
|---|---|
 |
 |
Release - min_version (checking PrettyPrintJSONDocument not being set with C116)
Verification PASSED on Win 11 x64 using the following build(s):
Brave | 1.57.64 Chromium: 116.0.5845.188 (Official Build) (64-bit)
-- | --
Revision | 25c5f0154a27707e95614f4ae5c79975958e2d09
OS | Windows 11 Version 22H2 (Build 22621.2361)
- downloaded/installed
1.57.64 Chromium: 116.0.5845.188and startedBraveusing the followingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
PrettyPrintJSONDocumentisn't visible underbrave://version
Example |
Example |
|---|---|
 |
 |
- restarted
Braveusingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed - ensured that
PrettyPrintJSONDocument:Disabled_EmergencyKillSwitchis not being set viabrave://version
|
|
Example |
Example |
|---|---|
 |
 |
BETA - PrettyPrintJSONDocument:Disabled_EmergencyKillSwitch
Verification PASSED on Pixel 6 running Android 14 using the following build(s):
Brave | 1.59.107 Chromium: 117.0.5938.140 (Official Build) beta (64-bit)
--- | ---
Revision | 5bbd53ed3e41461e15555b7ce0490464656b236f
OS | Android 14; Build/U1B1.230908.003; 34; REL
- downloaded/installed
1.59.107 Chromium: 117.0.5938.140and started `Brave - ensured that
PrettyPrintJSONDocument:Disabled_EmergencyKillSwitchviabrave://version - using the STR/Cases outlined via https://bugs.chromium.org/p/chromium/issues/detail?id=1485880, ensured that https://club.jd.com/comment/skuProductPageComments.action?productId=100066896420&score=0&sortType=6&page=0&pageSize=10&isShadowSku=0&fold=1 was loading without issues
Example |
Example |
|---|---|
 |
 |
Release - PrettyPrintJSONDocument:Disabled_EmergencyKillSwitch
Verification PASSED on Pixel 6 running Android 14 using the following build(s):
Brave | 1.58.135 Chromium: 117.0.5938.140 (Official Build) (64-bit)
--- | ---
Revision | 325e8592cad8c6badb656cab238b722ae46bf7bc
OS | Android 14; Build/U1B1.230908.003; 34; REL
- downloaded/installed
1.58.135 Chromium: 117.0.5938.140and started `Brave - ensured that
PrettyPrintJSONDocument:Disabled_EmergencyKillSwitchviabrave://version - using the STR/Cases outlined via https://bugs.chromium.org/p/chromium/issues/detail?id=1485880, ensured that https://club.jd.com/comment/skuProductPageComments.action?productId=100066896420&score=0&sortType=6&page=0&pageSize=10&isShadowSku=0&fold=1 was loading without issues
Example |
Example |
|---|---|
 |
 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.