Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing nightly #2094

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Fixing nightly #2094

merged 1 commit into from
Mar 27, 2019

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Mar 27, 2019

Description

To revert C74, PR #2088 was merged unintentionally instead of #2079.

See more details here: https://bravesoftware.slack.com/archives/CA5FPHWLF/p1553697892501200?thread_ts=1553678935.487200&cid=CA5FPHWLF

Instead of re-reverting the original PR and pushing the new pr, @mihaiplesa and I worked on a PR that has the missing commits from #2079.

From #2079 :

Related: brave/brave-browser#3896

Reverts:
brave/brave-browser#3790
#2029
#2072

Fixes brave/brave-browser#3898

Unfixes:
brave/brave-browser#3502
brave/brave-browser#3662
brave/brave-browser#3816

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Go into Jenkins for this PR
  2. Verify everything passes on all platforms
  3. If anything fails, don't merge

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@jumde jumde requested a review from mihaiplesa March 27, 2019 16:30
@jumde
Copy link
Contributor Author

jumde commented Mar 27, 2019

PR builder passed here: https://staging.ci.brave.com/job/brave-browser-build-pr/job/test_nightly/2/
( the network-audit on mac failure is because of a known revert #3816)

@jumde jumde merged commit 25f9807 into master Mar 27, 2019
@jumde jumde mentioned this pull request Mar 27, 2019
19 tasks
@bsclifton bsclifton added this to the 0.64.x - Nightly milestone Mar 28, 2019
@bsclifton bsclifton deleted the test_nightly branch March 28, 2019 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chromium 74 update is breaking nightly build
3 participants