fix(wallet): allow marking any NFT as junk or not junk

[josheleonard]

Resolves brave/brave-browser#36399
Resolves brave/brave-browser#36400
Resolves brave/brave-browser#34763

Cleans up the token management logic and allows spam NFTs to be marked as "not junk"

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

See STR in issues

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[Douglashdaniel]

++

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[github-actions]

[puLL-Merge] - brave/brave-core@21290

Description

This PR makes several major changes to the Brave Wallet UI components, focusing on refactoring actions and hooks related to asset management. The primary motivation appears to be code simplification and the removal of deprecated or unnecessary functionalities.

Changes

Changes

General Changes Across Multiple Files

• Removed unnecessary and deprecated code related to asset management, including specific actions for adding, updating, and removing user assets.
• Introduced new hooks and updated existing ones to use the API slice directly for mutations related to user asset visibility, adding, and removing tokens.
• Refactored components to utilize these new patterns, simplifying their logic and making them more maintainable.

Specific File Changes

• wallet_actions.ts & handlers.ts: Significant refactoring around asset management actions. Removed outdated actions and handlers, including those for adding and removing assets.
• lib.ts, action_types.ts, local-storage-keys.ts: Updated to reflect changes in how assets are handled, particularly around visibility and storage.
• assets-management.test.tsx & assets-management.ts: Removed these files as their functionalities have been refactored into new patterns.
• wallet-selectors.ts: Updated selectors to remove references to removed state properties.
• nfts.endpoints.ts & token.endpoints.ts: Adjusted API endpoints and handlers to align with the new asset management approach.
• blockchain-token.entity.ts & wallet.slice.ts: Updated to streamline state management and remove deprecated functionalities.
• UI components (nft-view.tsx, nft-grid-view.tsx, etc.): Updated to use new hooks for asset visibility and management. Simplified logic by removing deprecated hooks and actions.

Security Hotspots

1. Use of Local Storage (High Risk): Changes in local-storage-keys.ts and related files could potentially expose sensitive information if not handled correctly. Ensure that only non-sensitive data is stored in local storage and that proper access controls are in place.
2. API Mutations (Medium Risk): The refactoring introduces several new mutation hooks (useAddUserTokenMutation, useRemoveUserTokenMutation, useUpdateUserAssetVisibleMutation). It's crucial to ensure these mutations are securely handled, especially regarding authentication and data validation, to prevent unauthorized access or manipulation.
3. Asset Visibility Changes (Low Risk): Changes to asset visibility handling might inadvertently expose hidden assets if not properly managed. Review the logic surrounding these changes to ensure that asset visibility states are correctly updated and persisted.

[brave-builds]

A Storybook has been deployed to preview UI for the latest push