-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add brave-ios
repo & git history
#21961
Conversation
…s with Basic Challenge (brave/brave-ios#8152)
…re starting again (brave/brave-ios#8161)
… reorder via drag & drop for iPad (brave/brave-ios#8164)
…ort is added later (brave/brave-ios#8170) This is only supported for new users since a new preference is required to track language check failures
…act-width iPads (brave/brave-ios#8184) Unfortunately PanModal enforces the presentation to a `popover` on iPads regardless of size classes, so we must allow the arrow direction to be `down` as well here since the toolbar will be at the bottom on compact-width size classes. This also means that on iPads even with iPhone layouts they get shown as a popover which is not ideal and should be fixed later.
* Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md
…still shown after an external link opened via the 3P app (brave/brave-ios#8186)
…#8195) This is a 1.59.x release candidate and includes a fresh install launch crash fix
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.29 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.29...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ve/brave-ios#8202) The tabs bar now has a background and in general colors around these have changed so we can now just set the alpha of the tabs bar entirely instead of the subviews alone
* Integrate Portfolio v2 UI * Remove floating Buy/Send/Swap button * Use reusable modifier for reading view size
Resolved the rest of the semgrep alerts. Thanks for pinging @thypon |
A Storybook has been deployed to preview UI for the latest push |
…ave/brave-ios#8751) Fix race condition when an account is added while balances & prices are being fetched
4c8ebeb
to
9f4f494
Compare
The following commits were not verified: |
<g id="Group_3"> | ||
<path id="Vector_5" d="M320.617 1938.66C322.01 1938.66 323.34 1938.45 324.606 1938.01C325.872 1937.58 327.036 1936.97 328.097 1936.19C329.158 1935.41 330.081 1934.49 330.866 1933.43C331.65 1932.37 332.259 1931.2 332.692 1929.93C333.125 1928.66 333.341 1927.34 333.341 1925.95C333.341 1924.56 333.125 1923.23 332.692 1921.96C332.259 1920.69 331.65 1919.53 330.866 1918.47C330.081 1917.41 329.158 1916.48 328.097 1915.7C327.036 1914.92 325.871 1914.31 324.601 1913.87C323.332 1913.44 322 1913.22 320.607 1913.22C319.214 1913.22 317.884 1913.44 316.618 1913.87C315.351 1914.31 314.189 1914.92 313.131 1915.7C312.073 1916.48 311.152 1917.41 310.368 1918.47C309.583 1919.53 308.976 1920.69 308.546 1921.96C308.117 1923.23 307.902 1924.56 307.902 1925.95C307.902 1927.34 308.118 1928.66 308.551 1929.93C308.984 1931.2 309.591 1932.37 310.373 1933.43C311.154 1934.49 312.075 1935.41 313.136 1936.19C314.197 1936.97 315.361 1937.58 316.627 1938.01C317.894 1938.45 319.223 1938.66 320.617 1938.66ZM320.617 1936.85C319.412 1936.85 318.265 1936.66 317.174 1936.3C316.084 1935.93 315.086 1935.41 314.181 1934.75C313.276 1934.08 312.49 1933.3 311.823 1932.39C311.155 1931.48 310.639 1930.48 310.275 1929.39C309.91 1928.3 309.728 1927.15 309.728 1925.95C309.728 1924.74 309.91 1923.59 310.275 1922.5C310.639 1921.41 311.154 1920.41 311.818 1919.5C312.482 1918.59 313.266 1917.8 314.171 1917.14C315.076 1916.48 316.074 1915.96 317.165 1915.6C318.255 1915.23 319.402 1915.05 320.607 1915.05C321.818 1915.05 322.969 1915.23 324.059 1915.6C325.15 1915.96 326.149 1916.48 327.057 1917.14C327.965 1917.8 328.751 1918.59 329.415 1919.5C330.08 1920.41 330.596 1921.41 330.963 1922.5C331.331 1923.59 331.515 1924.74 331.515 1925.95C331.522 1927.15 331.343 1928.3 330.978 1929.39C330.613 1930.48 330.098 1931.48 329.43 1932.39C328.763 1933.3 327.975 1934.08 327.067 1934.75C326.159 1935.41 325.159 1935.93 324.069 1936.3C322.978 1936.66 321.828 1936.85 320.617 1936.85ZM314.845 1925.95C314.845 1926.2 314.931 1926.41 315.104 1926.58C315.277 1926.75 315.496 1926.83 315.763 1926.83H319.708V1930.78C319.708 1931.05 319.791 1931.27 319.957 1931.44C320.123 1931.61 320.337 1931.7 320.597 1931.7C320.864 1931.7 321.084 1931.62 321.256 1931.45C321.429 1931.28 321.515 1931.06 321.515 1930.78V1926.83H325.47C325.737 1926.83 325.955 1926.75 326.124 1926.58C326.294 1926.41 326.378 1926.2 326.378 1925.95C326.378 1925.68 326.294 1925.45 326.124 1925.29C325.955 1925.12 325.737 1925.03 325.47 1925.03H321.515V1921.09C321.515 1920.81 321.429 1920.59 321.256 1920.42C321.084 1920.24 320.864 1920.16 320.597 1920.16C320.337 1920.16 320.123 1920.24 319.957 1920.42C319.791 1920.59 319.708 1920.81 319.708 1921.09V1925.03H315.763C315.49 1925.03 315.268 1925.12 315.099 1925.29C314.93 1925.45 314.845 1925.68 314.845 1925.95Z" fill="black"/> | ||
</g> | ||
<text id="Design Variations" fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" font-weight="bold" letter-spacing="0em"><tspan x="263" y="1952.73">Design Variations</tspan></text> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<path id="Vector_5" d="M320.617 1938.66C322.01 1938.66 323.34 1938.45 324.606 1938.01C325.872 1937.58 327.036 1936.97 328.097 1936.19C329.158 1935.41 330.081 1934.49 330.866 1933.43C331.65 1932.37 332.259 1931.2 332.692 1929.93C333.125 1928.66 333.341 1927.34 333.341 1925.95C333.341 1924.56 333.125 1923.23 332.692 1921.96C332.259 1920.69 331.65 1919.53 330.866 1918.47C330.081 1917.41 329.158 1916.48 328.097 1915.7C327.036 1914.92 325.871 1914.31 324.601 1913.87C323.332 1913.44 322 1913.22 320.607 1913.22C319.214 1913.22 317.884 1913.44 316.618 1913.87C315.351 1914.31 314.189 1914.92 313.131 1915.7C312.073 1916.48 311.152 1917.41 310.368 1918.47C309.583 1919.53 308.976 1920.69 308.546 1921.96C308.117 1923.23 307.902 1924.56 307.902 1925.95C307.902 1927.34 308.118 1928.66 308.551 1929.93C308.984 1931.2 309.591 1932.37 310.373 1933.43C311.154 1934.49 312.075 1935.41 313.136 1936.19C314.197 1936.97 315.361 1937.58 316.627 1938.01C317.894 1938.45 319.223 1938.66 320.617 1938.66ZM320.617 1936.85C319.412 1936.85 318.265 1936.66 317.174 1936.3C316.084 1935.93 315.086 1935.41 314.181 1934.75C313.276 1934.08 312.49 1933.3 311.823 1932.39C311.155 1931.48 310.639 1930.48 310.275 1929.39C309.91 1928.3 309.728 1927.15 309.728 1925.95C309.728 1924.74 309.91 1923.59 310.275 1922.5C310.639 1921.41 311.154 1920.41 311.818 1919.5C312.482 1918.59 313.266 1917.8 314.171 1917.14C315.076 1916.48 316.074 1915.96 317.165 1915.6C318.255 1915.23 319.402 1915.05 320.607 1915.05C321.818 1915.05 322.969 1915.23 324.059 1915.6C325.15 1915.96 326.149 1916.48 327.057 1917.14C327.965 1917.8 328.751 1918.59 329.415 1919.5C330.08 1920.41 330.596 1921.41 330.963 1922.5C331.331 1923.59 331.515 1924.74 331.515 1925.95C331.522 1927.15 331.343 1928.3 330.978 1929.39C330.613 1930.48 330.098 1931.48 329.43 1932.39C328.763 1933.3 327.975 1934.08 327.067 1934.75C326.159 1935.41 325.159 1935.93 324.069 1936.3C322.978 1936.66 321.828 1936.85 320.617 1936.85ZM314.845 1925.95C314.845 1926.2 314.931 1926.41 315.104 1926.58C315.277 1926.75 315.496 1926.83 315.763 1926.83H319.708V1930.78C319.708 1931.05 319.791 1931.27 319.957 1931.44C320.123 1931.61 320.337 1931.7 320.597 1931.7C320.864 1931.7 321.084 1931.62 321.256 1931.45C321.429 1931.28 321.515 1931.06 321.515 1930.78V1926.83H325.47C325.737 1926.83 325.955 1926.75 326.124 1926.58C326.294 1926.41 326.378 1926.2 326.378 1925.95C326.378 1925.68 326.294 1925.45 326.124 1925.29C325.955 1925.12 325.737 1925.03 325.47 1925.03H321.515V1921.09C321.515 1920.81 321.429 1920.59 321.256 1920.42C321.084 1920.24 320.864 1920.16 320.597 1920.16C320.337 1920.16 320.123 1920.24 319.957 1920.42C319.791 1920.59 319.708 1920.81 319.708 1921.09V1925.03H315.763C315.49 1925.03 315.268 1925.12 315.099 1925.29C314.93 1925.45 314.845 1925.68 314.845 1925.95Z" fill="black"/> | ||
</g> | ||
<text id="Design Variations" fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" font-weight="bold" letter-spacing="0em"><tspan x="263" y="1952.73">Design Variations</tspan></text> | ||
<text id="Symbols are supported in up to nine weights and three scales." fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" letter-spacing="0em"><tspan x="263" y="1970.73">Symbols are supported in up to nine weights and three scales.</tspan></text> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</g> | ||
<text id="Design Variations" fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" font-weight="bold" letter-spacing="0em"><tspan x="263" y="1952.73">Design Variations</tspan></text> | ||
<text id="Symbols are supported in up to nine weights and three scales." fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" letter-spacing="0em"><tspan x="263" y="1970.73">Symbols are supported in up to nine weights and three scales.</tspan></text> | ||
<text id="For optimal layout with text and other symbols, vertically align" fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" letter-spacing="0em"><tspan x="263" y="1988.73">For optimal layout with text and other symbols, vertically align</tspan></text> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<text id="Design Variations" fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" font-weight="bold" letter-spacing="0em"><tspan x="263" y="1952.73">Design Variations</tspan></text> | ||
<text id="Symbols are supported in up to nine weights and three scales." fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" letter-spacing="0em"><tspan x="263" y="1970.73">Symbols are supported in up to nine weights and three scales.</tspan></text> | ||
<text id="For optimal layout with text and other symbols, vertically align" fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" letter-spacing="0em"><tspan x="263" y="1988.73">For optimal layout with text and other symbols, vertically align</tspan></text> | ||
<text id="symbols with the adjacent text." fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" letter-spacing="0em"><tspan x="263" y="2006.73">symbols with the adjacent text.</tspan></text> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</g> | ||
<path id="Vector_8" d="M793.197 1919V1933" stroke="#00AEEF" stroke-width="0.5"/> | ||
<text id="Margins" fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" font-weight="bold" letter-spacing="0em"><tspan x="776" y="1952.73">Margins</tspan></text> | ||
<text id="Leading and trailing margins on the left and right side of each symbol" fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" letter-spacing="0em"><tspan x="776" y="1970.73">Leading and trailing margins on the left and right side of each symbol</tspan></text> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<path id="Vector_9" d="M1291.84 1934.87L1293.54 1936.57C1293.97 1937.01 1294.42 1937.21 1294.9 1937.18C1295.38 1937.15 1295.85 1936.87 1296.31 1936.36L1307.01 1924.57L1306.04 1923.6L1295.43 1935.28C1295.25 1935.48 1295.07 1935.59 1294.89 1935.62C1294.71 1935.64 1294.51 1935.54 1294.27 1935.3L1293.1 1934.14C1292.87 1933.91 1292.76 1933.7 1292.79 1933.52C1292.82 1933.34 1292.94 1933.16 1293.14 1932.98L1304.62 1922.18L1303.64 1921.21L1292.05 1932.1C1291.55 1932.56 1291.29 1933.02 1291.25 1933.5C1291.22 1933.97 1291.41 1934.43 1291.84 1934.87ZM1298.26 1916.67C1298.05 1916.87 1297.93 1917.1 1297.91 1917.37C1297.88 1917.63 1297.93 1917.85 1298.04 1918.05C1298.16 1918.23 1298.33 1918.37 1298.56 1918.46C1298.78 1918.55 1299.06 1918.56 1299.38 1918.48C1300.11 1918.31 1300.85 1918.24 1301.6 1918.27C1302.35 1918.3 1303.08 1918.55 1303.79 1919.02L1303.21 1920.47C1303.04 1920.89 1302.99 1921.25 1303.07 1921.56C1303.14 1921.87 1303.31 1922.16 1303.58 1922.43L1305.87 1924.75C1306.12 1925 1306.35 1925.14 1306.58 1925.18C1306.81 1925.22 1307.06 1925.21 1307.34 1925.16L1308.4 1924.96L1309.07 1925.64L1309.03 1926.19C1309.01 1926.44 1309.04 1926.67 1309.12 1926.88C1309.2 1927.09 1309.36 1927.31 1309.61 1927.55L1310.37 1928.29C1310.61 1928.53 1310.87 1928.66 1311.15 1928.67C1311.44 1928.68 1311.7 1928.57 1311.93 1928.33L1314.84 1925.41C1315.07 1925.18 1315.19 1924.92 1315.18 1924.65C1315.18 1924.37 1315.05 1924.11 1314.81 1923.87L1314.04 1923.11C1313.8 1922.87 1313.58 1922.7 1313.38 1922.61C1313.17 1922.53 1312.95 1922.49 1312.71 1922.51L1312.13 1922.56L1311.49 1921.93L1311.73 1920.8C1311.8 1920.52 1311.79 1920.26 1311.7 1920.02C1311.6 1919.77 1311.41 1919.5 1311.12 1919.21L1308.92 1917.02C1308.09 1916.2 1307.2 1915.58 1306.26 1915.16C1305.32 1914.75 1304.37 1914.53 1303.42 1914.52C1302.47 1914.5 1301.55 1914.68 1300.66 1915.04C1299.78 1915.41 1298.98 1915.95 1298.26 1916.67ZM1299.75 1917.04C1300.36 1916.6 1301.01 1916.28 1301.7 1916.1C1302.39 1915.91 1303.1 1915.85 1303.8 1915.92C1304.51 1915.98 1305.2 1916.17 1305.87 1916.49C1306.54 1916.8 1307.15 1917.24 1307.7 1917.79L1310.13 1920.21C1310.25 1920.32 1310.32 1920.44 1310.35 1920.55C1310.38 1920.66 1310.38 1920.8 1310.34 1920.97L1310.02 1922.45L1311.52 1923.94L1312.51 1923.88C1312.63 1923.87 1312.72 1923.88 1312.79 1923.9C1312.85 1923.93 1312.94 1923.99 1313.03 1924.08L1313.61 1924.66L1311.17 1927.1L1310.59 1926.53C1310.49 1926.43 1310.43 1926.35 1310.41 1926.28C1310.38 1926.22 1310.37 1926.12 1310.38 1925.99L1310.45 1925.01L1308.95 1923.53L1307.43 1923.78C1307.26 1923.81 1307.14 1923.82 1307.04 1923.8C1306.95 1923.77 1306.84 1923.7 1306.71 1923.59L1304.71 1921.58C1304.58 1921.47 1304.51 1921.35 1304.49 1921.25C1304.48 1921.14 1304.51 1920.99 1304.59 1920.81L1305.46 1918.72C1304.68 1917.99 1303.8 1917.49 1302.83 1917.21C1301.85 1916.93 1300.86 1916.94 1299.84 1917.24C1299.76 1917.26 1299.71 1917.24 1299.69 1917.19C1299.67 1917.15 1299.69 1917.1 1299.75 1917.04Z" fill="black"/> | ||
</g> | ||
<text id="Exporting" fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" font-weight="bold" letter-spacing="0em"><tspan x="1289" y="1952.73">Exporting</tspan></text> | ||
<text id="Symbols should be outlined when exporting to ensure the" fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" letter-spacing="0em"><tspan x="1289" y="1970.73">Symbols should be outlined when exporting to ensure the</tspan></text> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</g> | ||
<text id="Exporting" fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" font-weight="bold" letter-spacing="0em"><tspan x="1289" y="1952.73">Exporting</tspan></text> | ||
<text id="Symbols should be outlined when exporting to ensure the" fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" letter-spacing="0em"><tspan x="1289" y="1970.73">Symbols should be outlined when exporting to ensure the</tspan></text> | ||
<text id="design is preserved when submitting to Xcode." fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" letter-spacing="0em"><tspan x="1289" y="1988.73">design is preserved when submitting to Xcode.</tspan></text> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<text id="Symbols should be outlined when exporting to ensure the" fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" letter-spacing="0em"><tspan x="1289" y="1970.73">Symbols should be outlined when exporting to ensure the</tspan></text> | ||
<text id="design is preserved when submitting to Xcode." fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" letter-spacing="0em"><tspan x="1289" y="1988.73">design is preserved when submitting to Xcode.</tspan></text> | ||
<text id="template-version" fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" letter-spacing="0em"><tspan x="2946" y="1932.73">Template v.3.0</tspan></text> | ||
<text id="Requires Xcode 13 or greater" fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" letter-spacing="0em"><tspan x="2857" y="1950.73">Requires Xcode 13 or greater</tspan></text> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<text id="template-version" fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" letter-spacing="0em"><tspan x="2946" y="1932.73">Template v.3.0</tspan></text> | ||
<text id="Requires Xcode 13 or greater" fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" letter-spacing="0em"><tspan x="2857" y="1950.73">Requires Xcode 13 or greater</tspan></text> | ||
<text id="descriptive-name" fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" letter-spacing="0em"><tspan x="2872" y="1968.73">Generated from brave.lock</tspan></text> | ||
<text id="Typeset at 100 points" fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" letter-spacing="0em"><tspan x="2903" y="1986.73">Typeset at 100 points</tspan></text> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<g id="Notes"> | ||
<path id="artboard" d="M3300 0H0V2200H3300V0Z" fill="white"/> | ||
<path id="Vector" d="M263 292H3036" stroke="black" stroke-width="0.5"/> | ||
<text id="Weight/Scale Variations" fill="black" xml:space="preserve" style="white-space: pre" font-family="Inter" font-size="13" font-weight="bold" letter-spacing="0em"><tspan x="263" y="321.727">Weight/Scale Variations</tspan></text> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let blockedXHR = false | ||
|
||
try { | ||
const response = await fetch("http://example.com/movies.json") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
[semgrep] Unencrypted request over HTTP detected.
Source: https://semgrep.dev/r/typescript.react.security.react-insecure-request.react-insecure-request
Cc @fmarier @thypon
"MenuItemCopyTitle" = "Kopieren"; | ||
|
||
/* Hide password text selection menu item */ | ||
"MenuItemHidePasswordTitle" = "Verbergen"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
[semgrep] A gitleaks hashicorp-tf-password was detected which attempts to identify hard-coded credentials. It is not recommended to store credentials in source-code, as this risks secrets being leaked and used by either an internal or external malicious adversary. It is recommended to use environment variables to securely provide credentials or retrieve credentials from a secure vault or HSM (Hardware Security Module).
Source: https://semgrep.dev/r/generic.secrets.gitleaks.hashicorp-tf-password.hashicorp-tf-password
Cc @fmarier @thypon
"MenuItemOpenTitle" = "Website öffnen"; | ||
|
||
/* Reveal password text selection menu item */ | ||
"MenuItemRevealPasswordTitle" = "Anzeigen"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
[semgrep] A gitleaks hashicorp-tf-password was detected which attempts to identify hard-coded credentials. It is not recommended to store credentials in source-code, as this risks secrets being leaked and used by either an internal or external malicious adversary. It is recommended to use environment variables to securely provide credentials or retrieve credentials from a secure vault or HSM (Hardware Security Module).
Source: https://semgrep.dev/r/generic.secrets.gitleaks.hashicorp-tf-password.hashicorp-tf-password
Cc @fmarier @thypon
"AuthPromptAlertMessageText" = "%@ verlangt die Eingabe eines Benutzernamens und Passworts."; | ||
|
||
/* Password textbox in Authentication prompt */ | ||
"AuthPromptAlertPasswordPlaceholderText" = "Passwort"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
[semgrep] A gitleaks hashicorp-tf-password was detected which attempts to identify hard-coded credentials. It is not recommended to store credentials in source-code, as this risks secrets being leaked and used by either an internal or external malicious adversary. It is recommended to use environment variables to securely provide credentials or retrieve credentials from a secure vault or HSM (Hardware Security Module).
Source: https://semgrep.dev/r/generic.secrets.gitleaks.hashicorp-tf-password.hashicorp-tf-password
Cc @fmarier @thypon
"login.loginInfoDetailsHeaderTitle" = "Anmeldedaten"; | ||
|
||
/* Title for the password field in password detail page */ | ||
"login.loginInfoDetailsPasswordFieldTitle" = "Passwort"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
[semgrep] A gitleaks hashicorp-tf-password was detected which attempts to identify hard-coded credentials. It is not recommended to store credentials in source-code, as this risks secrets being leaked and used by either an internal or external malicious adversary. It is recommended to use environment variables to securely provide credentials or retrieve credentials from a secure vault or HSM (Hardware Security Module).
Source: https://semgrep.dev/r/generic.secrets.gitleaks.hashicorp-tf-password.hashicorp-tf-password
Cc @fmarier @thypon
"LoginDetailLastModifiedCellFormatTitle" = "Ultima modifica: %@"; | ||
|
||
/* Label displayed above the password row in Login Detail View. */ | ||
"LoginDetailPasswordCellTitle" = "password"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
[semgrep] A gitleaks hashicorp-tf-password was detected which attempts to identify hard-coded credentials. It is not recommended to store credentials in source-code, as this risks secrets being leaked and used by either an internal or external malicious adversary. It is recommended to use environment variables to securely provide credentials or retrieve credentials from a secure vault or HSM (Hardware Security Module).
Source: https://semgrep.dev/r/generic.secrets.gitleaks.hashicorp-tf-password.hashicorp-tf-password
Cc @fmarier @thypon
"MenuItemCopyTitle" = "Salin"; | ||
|
||
/* Hide password text selection menu item */ | ||
"MenuItemHidePasswordTitle" = "Sembunyikan"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
[semgrep] A gitleaks hashicorp-tf-password was detected which attempts to identify hard-coded credentials. It is not recommended to store credentials in source-code, as this risks secrets being leaked and used by either an internal or external malicious adversary. It is recommended to use environment variables to securely provide credentials or retrieve credentials from a secure vault or HSM (Hardware Security Module).
Source: https://semgrep.dev/r/generic.secrets.gitleaks.hashicorp-tf-password.hashicorp-tf-password
Cc @fmarier @thypon
"wallet.highToLowSortOption" = "Absteigend"; | ||
|
||
/* A title above a text field that is used to enter a password */ | ||
"wallet.importAccountOriginPasswordTitle" = "Ursprungspasswort"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
[semgrep] A gitleaks hashicorp-tf-password was detected which attempts to identify hard-coded credentials. It is not recommended to store credentials in source-code, as this risks secrets being leaked and used by either an internal or external malicious adversary. It is recommended to use environment variables to securely provide credentials or retrieve credentials from a secure vault or HSM (Hardware Security Module).
Source: https://semgrep.dev/r/generic.secrets.gitleaks.hashicorp-tf-password.hashicorp-tf-password
Cc @fmarier @thypon
"wallet.passwordsDontMatchError" = "Kata laluan yang disahkan itu tidak sepadan"; | ||
|
||
/* A label will be displayed beside input password when it is considered as a medium password */ | ||
"wallet.passwordStatusMedium" = "Sederhana"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
[semgrep] A gitleaks hashicorp-tf-password was detected which attempts to identify hard-coded credentials. It is not recommended to store credentials in source-code, as this risks secrets being leaked and used by either an internal or external malicious adversary. It is recommended to use environment variables to securely provide credentials or retrieve credentials from a secure vault or HSM (Hardware Security Module).
Source: https://semgrep.dev/r/generic.secrets.gitleaks.hashicorp-tf-password.hashicorp-tf-password
Cc @fmarier @thypon
XCTAssertEqual(passwordStatus, .invalid) | ||
|
||
let validWeakPassword = "12345678" | ||
passwordStatus = await store.validatePassword(validWeakPassword) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
[semgrep] A gitleaks hashicorp-tf-password was detected which attempts to identify hard-coded credentials. It is not recommended to store credentials in source-code, as this risks secrets being leaked and used by either an internal or external malicious adversary. It is recommended to use environment variables to securely provide credentials or retrieve credentials from a secure vault or HSM (Hardware Security Module).
Source: https://semgrep.dev/r/generic.secrets.gitleaks.hashicorp-tf-password.hashicorp-tf-password
Cc @fmarier @thypon
A Storybook has been deployed to preview UI for the latest push |
This reverts commit 507e227.
This adds the contents and git history of https://github.com/brave/brave-ios to the
ios/brave-ios
directory.See #21553 for the migration where presubmits/linters are fixed properly
Resolves
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: