-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make proper native theme observer gets native theme change noti #2219
Conversation
Chromium supports dark theme on Windows since C74. So, brave should get proper native theme change noti when os theme changes because brave uses two native theme - default and native theme dark aura.
kindly ping.. |
@simonhong after discussing with @srirambv and @rebron, we decided it's too late to get this into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay, thanks for the fix @simonhong
@petemill NP! thanks for review :) |
Chromium supports dark theme on Windows since C74.
So, brave should get proper native theme change noti when os theme
changes because brave uses two native theme - default and native theme
dark aura.
Fix brave/brave-browser#4059
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Specified in brave/brave-browser#4059
Reviewer Checklist: