Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make proper native theme observer gets native theme change noti #2219

Merged
merged 1 commit into from
Apr 24, 2019

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Apr 14, 2019

Chromium supports dark theme on Windows since C74.
So, brave should get proper native theme change noti when os theme
changes because brave uses two native theme - default and native theme
dark aura.

Fix brave/brave-browser#4059

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Specified in brave/brave-browser#4059

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Chromium supports dark theme on Windows since C74.
So, brave should get proper native theme change noti when os theme
changes because brave uses two native theme - default and native theme
dark aura.
@simonhong simonhong added this to the 0.65.x - Nightly milestone Apr 14, 2019
@simonhong simonhong requested a review from petemill April 14, 2019 21:44
@simonhong simonhong self-assigned this Apr 14, 2019
@simonhong
Copy link
Member Author

kindly ping..

@simonhong
Copy link
Member Author

@petemill @kjozwiak I think it would be good to have this fix in our next stable release.

@kjozwiak
Copy link
Member

@simonhong after discussing with @srirambv and @rebron, we decided it's too late to get this into 0.63.x as we're basically releasing in a few days. Even though not ideal, there's a workaround of restarting the browser. However, we agreed that this should go into 0.64.x. Can you get the appropriate PR/Uplift requests created?

@simonhong
Copy link
Member Author

@kjozwiak yup! I'll make uplift PR up to 0.64.x after @petemill finishes review.

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay, thanks for the fix @simonhong

@simonhong
Copy link
Member Author

simonhong commented Apr 24, 2019

Apologies for the delay, thanks for the fix @simonhong

@petemill NP! thanks for review :)

@simonhong simonhong merged commit fa6a1c9 into master Apr 24, 2019
@simonhong simonhong deleted the align_windows_os_theme_with_brave_theme branch April 24, 2019 00:30
brave-builds pushed a commit that referenced this pull request Apr 24, 2019
brave-builds pushed a commit that referenced this pull request Apr 24, 2019
brave-builds pushed a commit that referenced this pull request Apr 24, 2019
simonhong pushed a commit that referenced this pull request Apr 28, 2019
simonhong pushed a commit that referenced this pull request Apr 28, 2019
bsclifton pushed a commit that referenced this pull request May 7, 2019
simonhong pushed a commit that referenced this pull request May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong colors when changing system colors to Light
3 participants