-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make proper native theme observer gets native theme change noti (uplift to 0.65.x) #2331
Make proper native theme observer gets native theme change noti (uplift to 0.65.x) #2331
Conversation
2153585
to
25830f7
Compare
@bsclifton Can you help to pass this PR on builder?
|
Will look at this soon- likely a Git cache issue |
25830f7
to
6d01e52
Compare
Rebased - will watch CI |
Tests run/pass on Linux and macOS; Windows runs into this problem:
|
Root problem discovered and captured in brave/brave-browser#4343 @petemill attempted a solution in #2384 Would be good to know if this happens on Windows with raw |
6d01e52
to
c4f3757
Compare
Rebased and re-run Builder and only lint check was failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uplift to 0.65.x
approved after deliberating with @srirambv. Please ensure that all the correct labels are being used and the appropriate issue(s) are moved into the correct milestone.
Uplift of #2219
Issue: brave/brave-browser#4059