Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables bg playback flag on Android by default #24037

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented Jun 6, 2024

Resolves brave/brave-browser#38869

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Install Brave
  2. Open Settings->Media
  3. Make sure Background playback option is on.

@SergeyZhukovsky SergeyZhukovsky added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Jun 6, 2024
@SergeyZhukovsky SergeyZhukovsky changed the title Enabled bg playback flag on Android by default Enables bg playback flag on Android by default Jun 6, 2024
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@SergeyZhukovsky SergeyZhukovsky merged commit 77994bd into master Jun 6, 2024
20 checks passed
@SergeyZhukovsky SergeyZhukovsky deleted the android_bg_playback_flag_enabled branch June 6, 2024 17:13
@github-actions github-actions bot added this to the 1.69.x - Nightly milestone Jun 6, 2024
brave-builds added a commit that referenced this pull request Jun 6, 2024
brave-builds added a commit that referenced this pull request Jun 6, 2024
@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 Pro running Android 14 using the following build(s):

Brave | 1.69.13 Chromium: 126.0.6478.56 (Official Build) canary (64-bit)
--- | ---
Revision | 1565a6462a0191b7cd42f4f893be370c7039c784
OS | Android 14; Build/AP21.240305.006; 34; REL

Went through the STR/Cases mentioned via #10408 (comment) and changed the URL to https://variations.bravesoftware.com/seedFake so it doesn't pull the seed on startup.

kjozwiak@kjozwiak-VMUbuntu:~$ adb shell "echo 'https://variations.bravesoftware.com/seedFake' > /data/local/tmp/brave-test-variations-server-url"
* daemon not running; starting now at tcp:5037
* daemon started successfully
  • launched Brave and ensured that brave://version doesn't list any variation studies due to using the incorrect URL
  • ensured that Background playback is enabled by default as per Enables bg playback flag on Android by default #24037 (comment)
  • ensured that YT clips/videos are being played in the background without any issues
Example Example Example
Screenshot_20240612-132203 Screenshot_20240612-132258 Screenshot_20240612-132339

kjozwiak pushed a commit that referenced this pull request Jun 12, 2024
kjozwiak pushed a commit that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable background playback by default
3 participants