Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enables bg playback flag on Android by default (uplift to 1.68.x) #24043

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Enables bg playback flag on Android by default (uplift to 1.68.x) #24043

merged 1 commit into from
Jun 12, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jun 6, 2024 •
edited by kjozwiak
Loading

Uplift of #24037
Resolves brave/brave-browser#38869

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team June 6, 2024 17:16
@brave-builds brave-builds added this to the 1.68.x - Beta milestone Jun 6, 2024
@brave-builds brave-builds self-assigned this Jun 6, 2024
@SergeyZhukovsky SergeyZhukovsky added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Jun 6, 2024
kjozwiak
kjozwiak approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.68.x approved 👍 QA has verified the PR on Nightly using 1.69.x as per #24037 (comment).

@kjozwiak kjozwiak merged commit 83366f7 into 1.68.x Jun 12, 2024
14 of 16 checks passed
@kjozwiak kjozwiak deleted the pr24037_android_bg_playback_flag_enabled_1.68.x branch June 12, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
1.68.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @SergeyZhukovsky