-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent search suggestions from clipboard text #25118
Conversation
A Storybook has been deployed to preview UI for the latest push |
b5edd71
to
8055e66
Compare
0177e61
to
a48ac46
Compare
@brave/sec-team PTAL! |
a48ac46
to
c2a0315
Compare
c2a0315
to
3224805
Compare
3224805
to
eef7417
Compare
fix brave/brave-browser#40415 It's hard to know whether current omnibox input is from clipboard past. So, prevent search suggestions if current input is same with clipboard text.
eef7417
to
855cd92
Compare
…clipboard Prevent search suggestions from clipboard text
Verified with
Using
Using
|
* Uplift of #25161 (squashed) to beta * Merge pull request #25099 from brave/rename_to_show_search_suggestions Renamed to `Show search suggestions` in search engine settings * Merge pull request #25118 from brave/prevent_search_suggestions_from_clipboard Prevent search suggestions from clipboard text * Merge pull request #25243 from brave/prevent_search_suggestions_for_suspicious_query Improve query check before sending to search suggestions server --------- Co-authored-by: Simon Hong <shong@brave.com>
fix brave/brave-browser#40415
It's hard to know whether current omnibox input is from clipboard past.
So, prevent search suggestion if current input is same with clipboard text.
Resolves
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
BraveSearchProviderTest.DontSendClipboardTextToSuggest
Improve search suggestions
in brave://settings/searchtext1
) to clipboardtext
text2
) to clipboard to cleartext1
from clipboardtext1
to clipboard and check search suggestions are visible